Got 12 planning #1466

sindresorhus · 2020-09-16T23:11:13Z

There are a few issues: https://github.com/sindresorhus/got/milestone/9

Anything else we want to change that is risky or breaking? It doesn't have to be a big breaking release though.

Rename lookup option to dnsLookup

Throw an error here:

Lines 138 to 149 in 2b40da2

    
           // TODO: Remove this in Got 12. 
        
           if (is.plainObject(url)) { 
        
           	const mergedOptions = { 
        
           		...url as Options, 
        
           		...options 
        
           	}; 
        
           	setNonEnumerableProperties([url as Options, options], mergedOptions); 
        
           	options = mergedOptions; 
        
           	url = undefined as any; 
        
           }

// @szmarczak @Giotino

The text was updated successfully, but these errors were encountered:

sindresorhus · 2020-09-16T23:14:19Z

@szmarczak I believe there was a breaking change we wanted to do to improve Node.js 15 compatibility?

szmarczak · 2020-09-16T23:24:39Z

Yes. It would introduce a new error event: retryError.

szmarczak · 2020-09-16T23:27:52Z

Should there be a separate branch for Got 12 development?

sindresorhus · 2020-09-16T23:33:53Z

I think #1353 would also be breaking.

sindresorhus · 2020-09-16T23:34:20Z

Should there be a separate branch for Got 12 development?

No, we can get out one more minor release and then switch the focus of master to v12.

Giotino · 2020-09-17T07:27:44Z

What about this? #1306 (comment)

By not sending Got options directly to the request module we can have more control on the request, and we can swap the underlying request module without breaking Got (e.g. testing Undici and use it if it suits our needs).

This does not have to be breaking. I think we can achieve this without changing the options and the behavior.

sindresorhus · 2020-09-17T10:51:44Z

What about this? #1306 (comment)

👍🏻 Yes, we can do that one too.

szmarczak · 2020-09-18T21:21:43Z

Unless there's anything else I think we can release 11.7.0.

sindresorhus · 2020-09-18T21:34:15Z

Unless there's anything else I think we can release 11.7.0.

Done: https://github.com/sindresorhus/got/releases/tag/v11.7.0

We can start preparing for Got 12 now.

Giotino · 2020-09-22T13:37:11Z

Should there be a separate branch for Got 12 development?

I think we should use a new branch before the release, in order to continue patching the current release, if needed.

sindresorhus · 2020-09-22T13:42:13Z

I'd rather do a v11 branch for that, if we need to backport.

kanongil · 2020-11-04T23:16:56Z

There is note that http2 will be enabled by default for v12. Is this still the case, given the poor state of http2 support in node.js?

szmarczak · 2020-11-04T23:29:07Z

Is this still the case, given the poor state of http2 support in node.js?

I think we'll stick to HTTP/1.1. HTTP/2 is too much broken as of now and needs many improvements on the Node.js side, that's why the http2-wrapper development has stopped for a while.

sffc · 2021-01-04T22:22:51Z

Thanks for maintaining this project!

Just as general feedback, the frequent major version bumps on Got are disruptive and make it hard to use. I'm currently juggling at least 3 versions of Got throughout my projects, and I am trying to migrate them all to version 11, but pretty soon they will all be out of date again. The differences between the versions are mostly small changes to option names (like "query" versus "searchParams", the semantics of the "json" option, etc). TypeScript helps this somewhat, but I thought I'd advocate for putting more of a priority on API stability and making minor version releases instead of major ones.

P.S. I support @sindresorhus on Patreon.

sindresorhus · 2021-01-05T04:26:29Z

@sffc Got 10 was a pretty large breaking release. Out of necessity. Got had amassed a lot of legacy and bloat and we felt we had to clean it up, otherwise, it would be too hard to maintain Got going forward. The JSON change was the most important change as the previous JSON behavior was both surprising to new users, limiting and buggy. I'm very glad we did that change. The query → searchParams change was probably not necessary, but it does help new users familiar with Fetch in the browser. Going forward we don't plan on doing a lot of breaking changes, but we do need to do some once in a while. Our release notes are always detailed with migration steps for every breaking change.

As you can see from the previous releases, we have done approximately one major release a year, which I think it's ok and what many larger projects do:

Got 9: Aug 4, 2018
Got 10: Dec 1, 2019
Got 11: Apr 20, 2020
Got 12: ~March 2021

Just know that we do care deeply about API stability.

sffc · 2021-01-05T21:15:37Z

Thanks! I have versions 6, 8, and 11 that I was reconciling. Glad to hear that the project is maturing with better stability moving forward.

bompus · 2021-02-17T17:29:58Z

Are there any plans to use undici for Got 12? I see it mentioned, but not sure what is involved with swapping in a different http request module.

sindresorhus · 2021-02-18T03:01:11Z

@bompus Not for Got 12, but we are closely following Undici development and might use it in the future.

sindresorhus · 2021-02-26T09:01:46Z

Just FYI. We're targeting Got v12 for the end of March.

Nytelife26 · 2021-03-04T15:39:02Z

I would suggest a bit of clean up with this release if possible. Ultimately, Got is way bigger than it needs to be, and also lacking in the performance department.
Compared with a simple low level HTTP library that can do almost everything Got can,

Got size (261kB bundle, 2MB install)
Centra fork size (10kB bundle and install)

Ultimately that is what has stopped me, all Kludge CS projects, Syrus, and many others from using Got. Just a bit of constructive criticism.

szmarczak · 2021-03-04T22:40:39Z

@Nytelife26 Most of the install size is TypeScript Node types. Consider opening an issue in the TypeScript repo.

sindresorhus · 2021-03-05T09:45:54Z

and also lacking in the performance department.

Any specifics or numbers to share? 🙏

Compared with a simple low-level HTTP library that can do almost everything Got can,

That is a common fallacy. From experience, the "almost" part eventually turns out to be much more. I'm talking from experience. Got actually started out as a 50 line package, but after years of being used in production, the messy reality of networking and countless of Node.js bugs has made Got larger than 50 lines.

szmarczak · 2021-03-14T17:43:56Z

I just noticed the more retries there are, the more errors will be created on promise.cancel():

got/source/as-promise/index.ts

Line 43 in 4cce4de

reject(new CancelError(request));

The solution is to move it before makeRequest and use global request instead.

szmarczak · 2021-03-14T19:04:00Z

got/source/as-promise/index.ts

Line 33 in 4cce4de

const request = new Request(undefined, normalizedOptions);

should reuse the previous request options on retry because promise.json() modifies the options

Nytelife26 · 2021-03-19T04:03:22Z

Any specifics or numbers to share?

Yes! I'm back with numbers, which you can see here, forked from your original Got benchmark suite (apologies for the delay).

off-topic

the "almost" part eventually turns out to be much more.

Name something you can do with Got and I'm certain I can do it with the other faster libraries too, even if it requires a little more effort (but then again such things tend to be out of scope at the library level anyway).

Got actually started out as a 50 line package

That's actually pretty impressive, I never would've guessed. A lot of your packages tend to be quite negatively impactful due to their oversharing amongst the ecosystem, however, you are definitely a competent developer in some respects.

szmarczak · 2021-03-20T22:52:55Z

off-topic

when it doesn't include what we're talking about.

I thought we were talking about features, weren't we?

NPM installs every different version every package uses.

Every package manager does this. Forcing upgrades is breaking.

while they're not useless, the harm outweighs the good in such cases.

I disagree here, but I'm not going to continue about this.

the comparison table is irrelevant when it doesn't include what we're talking about.

"it doesn't include what we're talking about" doesn't make your point clear as well. I have directly mentioned the word "feature" and kept on linking to the comparison table which shows Got features.

I'm also picking up a fair amount of passive-aggressiveness, which isn't entirely appreciated.

I'm not arguing, nor I'm going to. You have your own opinion - and that's right. I don't have to agree nor disagree.

"Ok, cool" is hardly a valid response to concerns or constructive criticism.

I don't think

I could do a lot of those things with the other packages, even if not out of the box.

is constructive criticism. You just expressed what you are capable of and it isn't about Got.

So here's the same reply but more comprehensive: I acknowledge that you are capable of providing the same features Got has. I'm not saying you must not. I'm not saying Got is better. I'm not saying your solution is wrong. Feel free to use what you are comfortable with.

I'm going to mark our comments as off-topic now. If you wish to continue this discussion / start a new one, don't hesitate to open a new issue.

szmarczak · 2021-07-22T13:21:25Z

Released first beta: https://github.com/sindresorhus/got/releases/tag/v12.0.0-beta.1

danm · 2021-10-27T13:02:33Z

Hi!, any idea when v12 will land - is beta.4 safe to use? Thanks! ❤️

szmarczak · 2021-10-27T18:04:52Z

is beta.4 safe to use?

Yes, it's safe to use. It's been running in production for a long long time. We will do a release as soon as possible.

sindresorhus · 2021-12-10T00:48:52Z

Closing as we'll be releasing v12 soon.

szmarczak · 2021-12-10T15:36:24Z

Released [email protected] 🎉

jfoclpf · 2023-05-15T18:26:29Z

My app started breaking in v12. Did you stop supporting require?

Error [ERR_REQUIRE_ESM]: require() of ES Module /home/joao/dev/geoapi.pt/node_modules/got/dist/source/index.js from /home/joao/dev/geoapi.pt/src/server/services/getNominatimData.js not supported.

Shinigami92 · 2023-05-15T18:36:20Z

My app started breaking in v12. Did you stop supporting require?

Error [ERR_REQUIRE_ESM]: require() of ES Module /home/joao/dev/geoapi.pt/node_modules/got/dist/source/index.js from /home/joao/dev/geoapi.pt/src/server/services/getNominatimData.js not supported.

Dude... NodeJS v14 reached EOL on 2023-04-30 https://github.com/nodejs/Release
Please upgrade to NodeJS v16 immediately!

jfoclpf · 2023-05-15T19:46:26Z

@Shinigami92 I'm using node 16, thus I don't get your comment

$ node -v
v16.20.0

and NodeJs has no plans for deprecating CommonsJS
nodejs/node#33954

Shinigami92 · 2023-05-15T19:48:01Z

@Shinigami92 I'm using node 16, thus I don't get your comment
$ node -v

v16.20.0

Oh don't mind me, sorry. I thought you referring to NodeJS v12, my bad

jfoclpf · 2023-05-15T19:54:00Z

I meant that the app started breaking at got v 12. Downgraded to got v 11 and it worked again. Why remove support for CJS?

modestfake · 2023-05-15T22:25:56Z

@jfoclpf you can read the reasoning here https://github.com/sindresorhus/got/releases/tag/v12.0.0

szmarczak pinned this issue Sep 16, 2020

szmarczak added this to the Got v12 milestone Sep 17, 2020

sindresorhus mentioned this issue Oct 5, 2020

Add lookup option documentation #1483

Merged

3 tasks

This comment has been minimized.

Sign in to view

szmarczak mentioned this issue Jun 9, 2021

Upgrade cacheable-request #1749

Closed

Logicer16 mentioned this issue Jun 9, 2021

normalize-url security vuln - update package-json to v6 yeoman/yo#673

Closed

AnWeber mentioned this issue Jun 28, 2021

RequestError: unable to verify the first certificate AnWeber/httpbook#23

Closed

sindresorhus closed this as completed Dec 10, 2021

sindresorhus unpinned this issue Dec 10, 2021

Got 12 planning #1466

Got 12 planning #1466

Comments

sindresorhus commented Sep 16, 2020 • edited by szmarczak Loading

sindresorhus commented Sep 16, 2020

szmarczak commented Sep 16, 2020

szmarczak commented Sep 16, 2020

sindresorhus commented Sep 16, 2020

sindresorhus commented Sep 16, 2020

Giotino commented Sep 17, 2020 • edited Loading

sindresorhus commented Sep 17, 2020

szmarczak commented Sep 18, 2020

sindresorhus commented Sep 18, 2020

Giotino commented Sep 22, 2020

sindresorhus commented Sep 22, 2020

kanongil commented Nov 4, 2020

szmarczak commented Nov 4, 2020

sffc commented Jan 4, 2021

sindresorhus commented Jan 5, 2021 • edited Loading

sffc commented Jan 5, 2021

bompus commented Feb 17, 2021

sindresorhus commented Feb 18, 2021

sindresorhus commented Feb 26, 2021

Nytelife26 commented Mar 4, 2021

szmarczak commented Mar 4, 2021

sindresorhus commented Mar 5, 2021

szmarczak commented Mar 14, 2021

szmarczak commented Mar 14, 2021

Nytelife26 commented Mar 19, 2021 • edited by szmarczak Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

szmarczak commented Mar 20, 2021 • edited Loading

This comment has been minimized.

szmarczak commented Jul 22, 2021

danm commented Oct 27, 2021

szmarczak commented Oct 27, 2021

sindresorhus commented Dec 10, 2021

szmarczak commented Dec 10, 2021

jfoclpf commented May 15, 2023

Shinigami92 commented May 15, 2023

jfoclpf commented May 15, 2023 • edited Loading

Shinigami92 commented May 15, 2023

jfoclpf commented May 15, 2023

modestfake commented May 15, 2023

sindresorhus commented Sep 16, 2020 •

edited by szmarczak

Loading

Giotino commented Sep 17, 2020 •

edited

Loading

sindresorhus commented Jan 5, 2021 •

edited

Loading

Nytelife26 commented Mar 19, 2021 •

edited by szmarczak

Loading

szmarczak commented Mar 20, 2021 •

edited

Loading

jfoclpf commented May 15, 2023 •

edited

Loading