Replace node-glob by fast-glob #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic 👍 |
kevva
suggested changes
Feb 12, 2018
gitignore.js
Outdated
| @@ -1,12 +1,19 @@ | |||
| 'use strict'; | |||
| const fs = require('fs'); | |||
| const path = require('path'); | |||
| const glob = require('glob'); | |||
| const fg = require('fast-glob'); | |||
There was a problem hiding this comment.
Name it fastGlob so that it's easier to understand what it is right away.
gitignore.js
Outdated
| @@ -72,7 +79,7 @@ const normalizeOpts = opts => { | |||
| module.exports = o => { | |||
| const opts = normalizeOpts(o); | |||
|
|
|||
| return globP('**/.gitignore', {ignore: opts.ignore, cwd: opts.cwd}) | |||
| return fg('**/.gitignore', {ignore: opts.ignore.concat(DEFAULT_IGNORE), cwd: opts.cwd}) | |||
There was a problem hiding this comment.
Do we want to be able to overwrite the default ones? I guess putting DEFAULT_IGNORE at the end would take precedence over the users?
index.js
Outdated
| @@ -1,11 +1,10 @@ | |||
| 'use strict'; | |||
| const arrayUnion = require('array-union'); | |||
| const glob = require('glob'); | |||
| const pify = require('pify'); | |||
| const fg = require('fast-glob'); | |||
|
@kevva thanks for the review. I made the changes you suggested. |
|
Also, I think these lines could be removed since |
|
Yes indeed. Good catch! |
|
@pvdlg Yay! A new |
|
yep, I'm on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per comment