Add support for Asar #378

dyoshikawa · 2020-07-14T14:24:27Z

Fixes #375

The official page of the file format

https://github.com/electron/asar#format

core.js

Richienb · 2020-07-14T14:37:28Z

// @sindresorhus

Richienb · 2020-07-14T14:38:36Z

@dyoshikawa In the pull request message, change For to Fixes so that the issue can be automatically closed.

dyoshikawa · 2020-07-14T14:40:26Z

@Richienb Thanks. Changed my message.

core.js

Co-authored-by: Richie Bendall <[email protected]>

core.js

Richienb · 2020-07-19T05:50:53Z

As it turns out, asar doesn't actually have a mime type so it should be set to application/octet-stream. electron/asar#199 (comment)

dyoshikawa · 2020-07-19T08:02:11Z

As it turns out, asar doesn't actually have a mime type so it should be set to application/octet-stream. electron/asar#199 (comment)

Can we use original mime type name?
ex. application/x-asar

Richienb · 2020-07-19T10:14:48Z

@dyoshikawa Not sure. Try asking that on electron/asar#199

dyoshikawa · 2020-07-19T10:36:59Z

@Richienb

https://www.iana.org/assignments/media-types/media-types.xhtml

Unregisterd mime types in this library seems to already exist.
ex. application/x-sqlite3, application/x-google-chrome-extension and more.

https://tools.ietf.org/html/rfc6838#section-3.4

Subtype names with "x." as the first facet may be used for types intended exclusively for use in private, local environments.

So application/x.asar looks good to me.

Richienb · 2020-07-19T11:27:44Z

🤷‍♂️

bencmbrook · 2020-07-21T22:55:33Z

Unregisterd mime types in this library seems to already exist.

These unregistered types are still used elsewhere so there's at least some traction behind them.

So application/x.asar looks good to me.

Since x. is "intended exclusively for use in private, local environments", it doesn't work here.

I don't think this library should create new MIME types. It should be the responsibility of the community around the format to decide on and register their MIME type. Given application/x-asar is not used elsewhere, I'd like to see this MIME as application/octet-stream.

Borewit · 2020-07-22T17:59:13Z

Consistent with existing code, I think we can use application/x-asar. /x- indicates an unregistered MIME-type.
We use an extensions and MIME-types to express the identified file type.
Both of them are not perfect. Wherever possible we shall comply with the standard.

core.js

dyoshikawa · 2020-07-26T08:54:35Z

@Borewit Thanks.
I rewrote checking logic by 2 steps.
And, I adopted application/x-asar as mime type.

package.json

readme.md

package.json

readme.md

Co-authored-by: Richie Bendall <[email protected]>

Borewit · 2020-07-27T06:51:52Z

core.js

+	if (buffer.length > 16 && checkString('{"files":{', {offset: 16})) {
+		try {
+			// Check header_size
+			buffer.readUInt32LE(4);


Unlike the comment suggests, there is in fact nothing checked here.
The header size is read, but the result is ignored.

Should the result not be used:

to check the format

determine the length of the JSON payload?

If required, note that buffer.readUInt32LE(4) can be executed safely on any file, as long as there are 4 bytes available.

Thanks.
I think this line should delete because your opinion.
Do you think so, too?

Borewit · 2020-07-27T06:57:39Z

core.js

@@ -1355,6 +1355,24 @@ async function _fromTokenizer(tokenizer) {
 			}
 		}
 	}
+
+	// Check for Asar
+	if (buffer.length > 16 && checkString('{"files":{', {offset: 16})) {


The checkString will only succeed if the string exist at that location, so no need to check the buffer length yourself.

Thx. I adopted it.

core.js

Co-authored-by: Richie Bendall <[email protected]>

Move the test in the "256-byte" group.

Gradually check if format is ASAR/Pickle.

dyoshikawa · 2020-07-29T06:54:02Z

core.js

@@ -1367,7 +1385,8 @@ const stream = readableStream => new Promise((resolve, reject) => {
 		const pass = new stream.PassThrough();
 		let outputStream;
 		if (stream.pipeline) {
-			outputStream = stream.pipeline(readableStream, pass, () => {});
+			outputStream = stream.pipeline(readableStream, pass, () => {


@Borewit
Is it needed?
This diff looks only a new line.

Best remove this newline.

dyoshikawa

@Borewit Thank you.
I adopted your suggesting code.

Richienb · 2020-07-29T07:05:20Z

core.js

@@ -1195,6 +1195,24 @@ async function _fromTokenizer(tokenizer) {
 		};
 	}

+	if (check([0x04, 0x00, 0x00, 0x00]) && buffer.length >= 16) { // Rough & quick check Pickle/ASAR


Are all of these comments necessary?

Richienb · 2020-08-01T16:39:04Z

@sindresorhus

dyoshikawa · 2020-08-04T04:24:59Z

Thank you for everyone!

Add support for Asar

aae6450

dyoshikawa mentioned this pull request Jul 14, 2020

Add asar support #375

Closed

replace space to tab

bd1eafc

Richienb suggested changes Jul 14, 2020

View reviewed changes

core.js Outdated Show resolved Hide resolved

simplify checking asar

98f4504

Richienb approved these changes Jul 14, 2020

View reviewed changes

Borewit requested changes Jul 14, 2020

View reviewed changes

core.js Outdated Show resolved Hide resolved

core.js Outdated Show resolved Hide resolved

dyoshikawa added 2 commits July 18, 2020 23:05

fix logic for checking asar

11364b6

add a fixture for asar

5e1fe55

dyoshikawa commented Jul 18, 2020

View reviewed changes

core.js Outdated Show resolved Hide resolved

core.js Outdated Show resolved Hide resolved

core.js Outdated Show resolved Hide resolved

Richienb suggested changes Jul 18, 2020

View reviewed changes

core.js Outdated Show resolved Hide resolved

fix using checkString

66b01d9

Co-authored-by: Richie Bendall <[email protected]>

dyoshikawa commented Jul 19, 2020

View reviewed changes

core.js Outdated Show resolved Hide resolved

fix single quote

f72bc24

Borewit requested changes Jul 22, 2020

View reviewed changes

core.js Outdated Show resolved Hide resolved

fix checking logic and mime-type

d0292b3

sindresorhus reviewed Jul 26, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

sindresorhus reviewed Jul 26, 2020

View reviewed changes

readme.md Outdated Show resolved Hide resolved

Richienb suggested changes Jul 26, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

readme.md Outdated Show resolved Hide resolved

dyoshikawa and others added 2 commits July 27, 2020 14:40

Update readme.md

870a3b9

Co-authored-by: Richie Bendall <[email protected]>

Update package.json

8688cd3

Co-authored-by: Richie Bendall <[email protected]>

Borewit requested changes Jul 27, 2020

View reviewed changes

Richienb suggested changes Jul 28, 2020

View reviewed changes

core.js Outdated Show resolved Hide resolved

dyoshikawa and others added 3 commits July 28, 2020 22:01

Update core.js

ad17ef0

Co-authored-by: Richie Bendall <[email protected]>

remove unneeded code

ae93869

Gradually check if format is ASAR/Pickle.

ee51d0d

Move the test in the "256-byte" group.

Borewit mentioned this pull request Jul 28, 2020

Gradually check if format is ASAR/Pickle. dyoshikawa/file-type#1

Merged

Merge pull request #1 from sindresorhus/optimize-asar

260aa19

Gradually check if format is ASAR/Pickle.

dyoshikawa commented Jul 29, 2020

View reviewed changes

Richienb suggested changes Jul 29, 2020

View reviewed changes

Borewit approved these changes Aug 1, 2020

View reviewed changes

Borewit merged commit f2ebb8d into sindresorhus:master Aug 1, 2020

dyoshikawa deleted the add-support-for-asar branch August 4, 2020 04:25

timojaask mentioned this pull request Oct 20, 2020

Asar support breaks on asar archives where JSON header size >= 240 #406

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Asar #378

Add support for Asar #378

dyoshikawa commented Jul 14, 2020 •

edited

Loading

Richienb commented Jul 14, 2020

Richienb commented Jul 14, 2020

dyoshikawa commented Jul 14, 2020

Richienb commented Jul 19, 2020

dyoshikawa commented Jul 19, 2020

Richienb commented Jul 19, 2020

dyoshikawa commented Jul 19, 2020

Richienb commented Jul 19, 2020

bencmbrook commented Jul 21, 2020 •

edited

Loading

Borewit commented Jul 22, 2020

dyoshikawa commented Jul 26, 2020

Borewit Jul 27, 2020

dyoshikawa Jul 28, 2020

Richienb Jul 28, 2020

dyoshikawa Jul 28, 2020

Borewit Jul 27, 2020

dyoshikawa Jul 28, 2020

dyoshikawa Jul 29, 2020

Richienb Jul 29, 2020

dyoshikawa left a comment

Richienb Jul 29, 2020

Richienb commented Aug 1, 2020

dyoshikawa commented Aug 4, 2020

Add support for Asar #378

Add support for Asar #378

Conversation

dyoshikawa commented Jul 14, 2020 • edited Loading

The official page of the file format

Richienb commented Jul 14, 2020

Richienb commented Jul 14, 2020

dyoshikawa commented Jul 14, 2020

Richienb commented Jul 19, 2020

dyoshikawa commented Jul 19, 2020

Richienb commented Jul 19, 2020

dyoshikawa commented Jul 19, 2020

Richienb commented Jul 19, 2020

bencmbrook commented Jul 21, 2020 • edited Loading

Borewit commented Jul 22, 2020

dyoshikawa commented Jul 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dyoshikawa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Richienb commented Aug 1, 2020

dyoshikawa commented Aug 4, 2020

dyoshikawa commented Jul 14, 2020 •

edited

Loading

bencmbrook commented Jul 21, 2020 •

edited

Loading