when rename is a function, basename does not contain the file extension from 9.x

[kittaakos]

Hi there,

Thank you for the great lib.

After bumping from 8.1.2 to 9.0.1, I noticed that when rename is a function, the basename argument no longer contains the file extension. Is it by design or a bug? The Breaking section of the release notes does not mention it.

8.1.2:

cpy/index.js

Lines 41 to 47 in 94fff3a

	let basename = path.basename(source);
	if (typeof options.rename === 'string') {
	basename = options.rename;
	} else if (typeof options.rename === 'function') {
	basename = options.rename(basename);
	}

9.0.1:

cpy/index.js

Lines 121 to 130 in 0a3dcbe

	const filename = path.basename(source, path.extname(source));
	const fileExtension = path.extname(source);
	const directory = path.dirname(source);
	if (typeof rename === 'string') {
	return path.join(directory, rename);
	}
	if (typeof rename === 'function') {
	return path.join(directory, `${rename(filename)}${fileExtension}`);
	}

index.js:

const { deepEqual } = require('assert');
const { promises: fs } = require('fs');
const { tmpdir } = require('os');
const { join } = require('path');

(async () => {
    const cpy = await import('cpy');
    const sourceDir = await fs.mkdtemp(join(tmpdir(), 'cpy-source'));
    const targetDir = await fs.mkdtemp(join(tmpdir(), 'cpy-target'));
    fs.writeFile(join(sourceDir, 'a.js'), '// js', { encoding: 'utf8' });
    fs.writeFile(join(sourceDir, 'a.ts'), '// ts', { encoding: 'utf8' });

    await cpy.default(sourceDir, targetDir, {
        rename: (basename) => {
            console.log('cpy#filter, basename:', basename);
            return basename; // It does not matter
        }
    });
    const files = await fs.readdir(targetDir);
    deepEqual(files.length, 2);
    deepEqual(files.includes('a.js'), true);
    deepEqual(files.includes('a.ts'), true);
})();

[email protected]:

% node index.js
cpy#filter, basename: a.js
cpy#filter, basename: a.ts

[email protected]:

% node index.js 
cpy#filter, basename: a
cpy#filter, basename: a

Thank you!

[sindresorhus]

This is a bug. It should include the extension.