Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Defaults module #32

Merged
merged 2 commits into from
Apr 16, 2018
Merged

Use the Defaults module #32

merged 2 commits into from
Apr 16, 2018

Conversation

sindresorhus
Copy link
Owner

It simplifies UserDefaults and makes it less fragile.

https://github.com/sindresorhus/Defaults

@LarsJK What do you think of this approach? I could also use a review of the Defaults module if you have time.

@sindresorhus sindresorhus requested a review from LarsJK April 11, 2018 18:59
LarsJK
LarsJK approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@LarsJK LarsJK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome 👍
Will have a look at sindresorhus/Defaults and comment on the Defaults wrapper there

@sindresorhus sindresorhus merged commit 1e0fd5f into master Apr 16, 2018
@sindresorhus sindresorhus deleted the defaults branch April 16, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LarsJK LarsJK LarsJK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sindresorhus @LarsJK