Support KVO for .isFinished and .isCancelled

Fixes #29
sindresorhus · Nov 12, 2020 · a292ebb · a292ebb
1 parent 322833a
commit a292ebb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/Sources/CircularProgress/CircularProgress.swift b/Sources/CircularProgress/CircularProgress.swift
@@ -129,6 +129,8 @@ public final class CircularProgress: NSView {
 	private var _isFinished = false
 	/**
 	Returns whether the progress is finished.
+
+	The property supports KVO.
 	*/
 	@IBInspectable public private(set) var isFinished: Bool {
 		get {
@@ -143,7 +145,9 @@ public final class CircularProgress: NSView {
 		set {
 			assertMainThread()
 
+			willChangeValue(for: \.isFinished)
 			_isFinished = newValue
+			didChangeValue(for: \.isFinished)
 
 			if _isFinished {
 				isIndeterminate = false
@@ -349,6 +353,8 @@ public final class CircularProgress: NSView {
 	private var _isCancelled = false
 	/**
 	Returns whether the progress has been cancelled.
+
+	The property supports KVO.
 	*/
 	@IBInspectable public private(set) var isCancelled: Bool {
 		get {
@@ -363,7 +369,9 @@ public final class CircularProgress: NSView {
 		set {
 			assertMainThread()
 
+			willChangeValue(for: \.isCancelled)
 			_isCancelled = newValue
+			didChangeValue(for: \.isCancelled)
 
 			if newValue {
 				onCancelled?()

diff --git a/readme.md b/readme.md
@@ -153,6 +153,8 @@ var onCancelled: (() -> Void)?
 
 /**
 Returns whether the progress is finished.
+
+The property supports KVO.
 */
 @IBInspectable var isFinished: Bool { get }
 
@@ -168,6 +170,8 @@ Displays the indeterminate state.
 
 /**
 Returns whether the progress has been cancelled.
+
+The property supports KVO.
 */
 @IBInspectable var isCancelled: Bool { get }