Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated installation instructions and fixed semantic-layer parsing error #1550

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

gdcsinaptik
Copy link
Collaborator

@gdcsinaptik gdcsinaptik commented Jan 27, 2025

Important

Update installation instructions to specify pandasai>=3.0.0b2 and fix comment syntax in semantic-layer.mdx.

  • Installation Instructions:
    • Update README.md and getting-started.mdx to specify pandasai>=3.0.0b2 for pip and poetry.
  • Semantic Layer Parsing:
    • Fix comment syntax in semantic-layer.mdx from {/* ... */} to /* ... */.

This description was created by Ellipsis for 5bd78be. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 27, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 5bd78be in 36 seconds

More details
  • Looked at 68 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. docs/v3/semantic-layer.mdx:393
  • Draft comment:
    Incorrect comment block syntax. Use proper comment syntax.
/* commented as destination and update frequency will be only in the materialized case */
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. docs/v3/semantic-layer.mdx:393
  • Draft comment:
    Ensure that comment blocks are properly closed. The correction from \*/ to /* end of materialized case comment */ is appropriate.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The comment block syntax was incorrect and has been corrected in the PR. This is a good change.

Workflow ID: wflow_rDLee3zMEMZHRtEh


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.63%. Comparing base (63e8c26) to head (5bd78be).
Report is 150 commits behind head on release/v3.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/v3    #1550      +/-   ##
==============================================
+ Coverage       79.09%   79.63%   +0.53%     
==============================================
  Files             149       59      -90     
  Lines            6013     2013    -4000     
==============================================
- Hits             4756     1603    -3153     
+ Misses           1257      410     -847     
Flag Coverage Δ
unittests 79.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gventuri gventuri changed the title updated installation instructions and fixed semantic-layer parsing error docs: updated installation instructions and fixed semantic-layer parsing error Jan 27, 2025
@gventuri gventuri merged commit 4c857ac into release/v3 Jan 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants