Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependency issue and updated lock files #1539

Merged

Conversation

scaliseraoul
Copy link
Contributor

@scaliseraoul scaliseraoul commented Jan 21, 2025


Important

Fixes dependency issues by updating Python and pandasai version constraints and adds Poetry validation hooks.

  • Dependencies:
    • Updated Python version constraints to >=3.8,<3.12 in pyproject.toml and various extensions.
    • Changed pandasai dependency to >=3.0.0-beta.0 in multiple pyproject.toml files.
  • Pre-commit Hooks:
    • Added poetry-check and poetry-lock hooks in .pre-commit-config.yaml for validating pyproject.toml and syncing poetry.lock.

This description was created by Ellipsis for ec1d034. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 21, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ec1d034 in 35 seconds

More details
  • Looked at 291 lines of code in 20 files
  • Skipped 19 files when reviewing.
  • Skipped posting 8 drafted comments based on config settings.
1. extensions/connectors/sql/pyproject.toml:10
  • Draft comment:
    Ensure consistent Python version constraints across all pyproject.toml files. Some files use >=3.9,<3.12 while others use >=3.8,<3.12. Consider standardizing this.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. extensions/connectors/sql/pyproject.toml:7
  • Draft comment:
    When library code changes, documentation should be updated accordingly. Please ensure that any necessary documentation updates are included in this PR.
  • Reason this comment was not posted:
    Comment did not seem useful.
3. extensions/connectors/sql/pyproject.toml:13
  • Draft comment:
    When library code changes, documentation should be updated accordingly. Please ensure that any necessary documentation updates are included in this PR.
  • Reason this comment was not posted:
    Marked as duplicate.
4. extensions/connectors/yfinance/pyproject.toml:7
  • Draft comment:
    When library code changes, documentation should be updated accordingly. Please ensure that any necessary documentation updates are included in this PR.
  • Reason this comment was not posted:
    Marked as duplicate.
5. extensions/connectors/yfinance/pyproject.toml:13
  • Draft comment:
    When library code changes, documentation should be updated accordingly. Please ensure that any necessary documentation updates are included in this PR.
  • Reason this comment was not posted:
    Marked as duplicate.
6. extensions/ee/connectors/bigquery/pyproject.toml:7
  • Draft comment:
    When library code changes, documentation should be updated accordingly. Please ensure that any necessary documentation updates are included in this PR.
  • Reason this comment was not posted:
    Marked as duplicate.
7. extensions/ee/connectors/bigquery/pyproject.toml:13
  • Draft comment:
    When library code changes, documentation should be updated accordingly. Please ensure that any necessary documentation updates are included in this PR.
  • Reason this comment was not posted:
    Marked as duplicate.
8. extensions/ee/connectors/databricks/pyproject.toml:7
  • Draft comment:
    When library code changes, documentation should be updated accordingly. Please ensure that any necessary documentation updates are included in this PR.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_ilLpUBp0Xi2CJmMA


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@gventuri gventuri merged commit 7967d07 into sinaptik-ai:release/v3 Jan 21, 2025
12 checks passed
scaliseraoul added a commit to scaliseraoul/pandas-ai that referenced this pull request Jan 21, 2025
* commit '7967d07f90866edc71f12fdac61761d0946712f8':
  fix: dependency issue and updated lock files (sinaptik-ai#1539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants