feature(View): add view support and relationship validation in SemanticLayerSchema #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
…into release/v3 * 'release/v3' of https://github.com/Sinaptik-AI/pandas-ai: fix(VirtualDataframe): fixing virtual dataframe name conflict (#1531)
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
…ing view in SemanticLayerSchema);
dosubot
bot
added
the
size:L
gventuri
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v3 #1534 +/- ##
==============================================
- Coverage 79.09% 77.97% -1.13%
==============================================
Files 149 58 -91
Lines 6013 1925 -4088
==============================================
- Hits 4756 1501 -3255
+ Misses 1257 424 -833
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses review comments left by @scaliseraoul on PR #1532: feature(View): enabling view in SemanticLayerSchema
Summary:
Enhance
SemanticLayerSchemato support views and relationships with new validation logic and tests.Key points:
SemanticLayerSchemawithviewattribute inSourceclass.tableandviewinSource.Relationclass to define relationships between columns in views.check_columns_relations()inSemanticLayerSchemato validate column uniqueness and format.[table].[column]format.semantic-layer.mdxto include view configuration and constraints.test_semantic_layer_schema.py.tableandview, column format, and relationship definitions.You can configure Ellipsis to address comments with a direct commit or a side PR, see docs.
Something look wrong? If this Pull Request doesn't address the comments left on the above pull request, create a new PR review with more details. For more information, check the documentation.
Generated with ❤️ by ellipsis.dev