Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the pool level support to set qos limits for lvol #41

Open
wants to merge 1 commit into
base: v24.05.x
Choose a base branch
from

Conversation

sangramsimplyblock
Copy link
Collaborator

1. Added the RPC to add/remove the lvols to/from pool.
2. Added RPC to et the QoS limits at pool level.
3. Before setting the limits at pool level limits the lvol needs to added to the pool. Same RPC is used to disable the qos limits. Use the limits value 0 to disable the limits. Again enabling the limits can be done on the group with valid limit values.
4. When lvol is deleted the bdev is removed from the pool.
5. When all the lvols in the pool are deleted the pool is also deleted so next time when new lvols are added the set limits on the group should be invoked.
6. Tested the code using the unit test exec_test_rate_limit.
7. Tested the code with ASAN build as well.
8. Restricted to set qos limits when lvol is part of pool and vice a versa.
9. Added the support of all 7 priority classes in lvol

    1. Added the RPC to add/remove the lvols to/from pool.
    2. Added RPC to et the QoS limits at pool level.
    3. Before setting the limits at pool level limits the lvol needs to added to the pool. Same RPC is used to disable the qos limits. Use the limits value 0 to disable the limits. Again enabling the limits can be done on the group with valid limit values.
    4. When lvol is deleted the bdev is removed from the pool.
    5. When all the lvols in the pool are deleted the pool is also deleted so next time when new lvols are added the set limits on the group should be invoked.
    6. Tested the code using the unit test exec_test_rate_limit.
    7. Tested the code with ASAN build as well.
    8. Restricted to set qos limits when lvol is part of pool and vice a versa.
    9. Added the support of all 7 priority classes in lvol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant