Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group vite packages together #5

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Group vite packages together #5

merged 1 commit into from
Nov 20, 2023

Conversation

Zinggi
Copy link
Member

@Zinggi Zinggi commented Nov 20, 2023

The ruby package and the vite js + plugin packages should be upgraded together

@Zinggi
Copy link
Member Author

Zinggi commented Nov 20, 2023

I haven't tested this, but I think it should work. Is there a way to test these changes?

@andyundso
Copy link
Contributor

I usually test it on regex101.com. otherwise, you can apply the rule in a single-project first before upstreaming.

@Zinggi
Copy link
Member Author

Zinggi commented Nov 20, 2023

The regex is correct.
@andyundso Do you think I should really test in on real project first? I would have just merged it, as it takes quite some time to test it.

Copy link
Contributor

@andyundso andyundso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead :)

@Zinggi Zinggi merged commit 71bc79d into main Nov 20, 2023
3 checks passed
@Zinggi Zinggi deleted the group-vite-updates branch November 20, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants