Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api keys in environment variables and helper class to do stuff with SimpleGeo Context results #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joncooper
Copy link

Hi there,

There are two things in this pull request:

  1. API keys in environment variables SIMPLEGEO_TOKEN and SIMPLEGEO_SECRET. This is helpful for testing, and also for deploying to environments like Heroku. I prefer to keep keys out of the codebase.
  2. A Context class, so that people can hang methods that ask questions about context results. My initial need was to do geographic resolution of IPs at a country level.

This is my first ever pull request so please excuse me if I've missed some point of etiquette here :)

Cheers,
Jon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant