Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ARIA roles to non-abstract values. Fix #167 #168

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Update ARIA roles to non-abstract values. Fix #167 #168

merged 1 commit into from
Oct 22, 2019

Conversation

lacymorrow
Copy link
Contributor

My opinions, there may be more valid non-abstract roles listed here: https://www.w3.org/TR/wai-aria-1.0/roles#roles_categorization

  • .pcr-app from role="window" to role="form"
  • .pcr-palette from role="widget" to role="listbox"
  • .pcr-opacity and .pcr-hue from role="widget" to role="slider"

@simonwep simonwep requested a review from NateSeymour October 20, 2019 13:47
@NateSeymour NateSeymour merged commit 4b030b0 into simonwep:master Oct 22, 2019
@NateSeymour
Copy link
Collaborator

Thank you for your contribution.

@simonwep simonwep mentioned this pull request Feb 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NateSeymour NateSeymour Awaiting requested review from NateSeymour

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lacymorrow @NateSeymour