Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the button strings type to string #165

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Change the button strings type to string #165

merged 1 commit into from
Oct 16, 2019

Conversation

zfanli
Copy link
Contributor

@zfanli zfanli commented Oct 16, 2019 •
edited
Loading

Cannot change button strings when using TypeScript.

(property) Pickr.Options.strings?: {
    save?: "Save" | undefined;
    clear?: "Clear" | undefined;
    cancel?: "Cancel" | undefined;
} | undefined

@zfanli
Change the button strings type to string
8c9a605 
Cannot change button strings when using TypeScript.

(property) Pickr.Options.strings?: {
    save?: "Save" | undefined;
    clear?: "Clear" | undefined;
    cancel?: "Cancel" | undefined;
} | undefined
@simonwep
Copy link
Owner

simonwep commented Oct 16, 2019 •
edited
Loading

Thanks :)

@simonwep simonwep merged commit 6ffe05c into simonwep:master Oct 16, 2019
@simonwep simonwep added the typescript Typescript / types related label Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
typescript Typescript / types related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zfanli @simonwep