Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button color not updating on iOS Safari #153

Closed
kkeith-adg opened this issue Sep 19, 2019 · 1 comment
Closed

Button color not updating on iOS Safari #153

kkeith-adg opened this issue Sep 19, 2019 · 1 comment
Assignees
Labels
browser quirk Deprecation, browser idiosyncrasies etc...

Comments

@kkeith-adg
Copy link

kkeith-adg commented Sep 19, 2019

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

Choosing color and hitting save doesn't update button color on iOS Safari.

If the current behavior is a bug, please provide the steps to reproduce and create a JSFiddle.

Go to demo page in Safari on device running iOS 12.1 (iPad Gen 6 in my case) and select color and save. Nothing happens with button color.

What is the expected behavior?

Button should update to selected color. When applying default color externally, it should update the button as well.

Your environment:

Version (see Pickr.version): 1.4.2
Used bundle (es5 or normal one): normal
Used theme (default is classic):  all
Browser-version: Safari 12.1
Operating-system:  iOS 12.1 on iPad Gen 6

Additional Notes

The main functionality seems to work fine. When I set the default color from my app, it doesn't show in the button like it does on a desktop browser, but it is correctly set in the modal. You can change the color and save which will produce the proper color, just not update the button UI.

On all the desktop browsers I've tried, the button color shows properly.

@NateSeymour
Copy link
Collaborator

NateSeymour commented Sep 19, 2019

Thank you for bringing attention to this issue! :)

It has been fixed in commit fd6232d, please let us know if you are having any more problems.

Have a wonderful day!

@simonwep simonwep added the browser quirk Deprecation, browser idiosyncrasies etc... label Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser quirk Deprecation, browser idiosyncrasies etc...
Projects
None yet
Development

No branches or pull requests

3 participants