Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Prettier via package.json #1170

Merged
merged 4 commits into from
Jan 4, 2021
Merged

Conversation

benpickles
Copy link
Contributor

This adds a package.json with Prettier and means that developers/CI will use the same version. It also ensures that NPM packages are cached on GitHub Actions which fixes #1169.

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #1170 (a5761cc) into main (1e8fa3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1170   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files          32       32           
  Lines        3932     3932           
=======================================
  Hits         3600     3600           
  Misses        332      332           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e8fa3a...a5761cc. Read the comment docs.

@benpickles
Copy link
Contributor Author

I was going to re-add the filter to only run Prettier when there have been changes in datasette/static but that would mean it wouldn't run when the package is updated. That plus the fact that the last run of the job took only 8 seconds is why I decided not to re-add the filter.

@benpickles benpickles marked this pull request as ready for review January 4, 2021 14:25
@simonw simonw merged commit 3054e0f into simonw:main Jan 4, 2021
@simonw
Copy link
Owner

simonw commented Jan 4, 2021

Thank you very much!

@benpickles benpickles deleted the cache-prettier branch January 5, 2021 12:44
simonw added a commit that referenced this pull request Jan 19, 2021
@simonw simonw added this to the Datasette 0.54 milestone Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier package not actually being cached
2 participants