Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasette-Lite failing with multipart import error #79

Closed
wragge opened this issue Oct 21, 2024 · 4 comments
Closed

Datasette-Lite failing with multipart import error #79

wragge opened this issue Oct 21, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@wragge
Copy link

wragge commented Oct 21, 2024

Datasette-Lite has started failing with the error:

Error

Traceback (most recent call last):
  File "/lib/python312.zip/_pyodide/_base.py", line 596, in eval_code_async
    await CodeRunner(
  File "/lib/python312.zip/_pyodide/_base.py", line 412, in run_async
    await coroutine
  File "<exec>", line 116, in <module>
  File "/lib/python3.12/site-packages/datasette/app.py", line 3, in <module>
    import asgi_csrf
  File "/lib/python3.12/site-packages/asgi_csrf.py", line 5, in <module>
    from multipart import FormParser
ModuleNotFoundError: No module named 'multipart'

It seems that the latest version of python-multipart has renamed the import, so I'm wondering if that's the problem?

@Kludex
Copy link

Kludex commented Oct 21, 2024

No. That's not the problem. I've yanked the release.

@wragge
Copy link
Author

wragge commented Oct 21, 2024

I've gotten my own Datasette-Lite repo to work for now by adding await micropip.install("python-multipart==0.0.12") into webworker.js. But I don't know why this works if the 0.0.13 version has been yanked.

@simonw simonw added the bug Something isn't working label Oct 22, 2024
@simonw
Copy link
Owner

simonw commented Oct 22, 2024

Wow, weird. Thanks @wragge for the workaround, I'll apply that for the moment.

simonw added a commit that referenced this issue Oct 22, 2024
@simonw
Copy link
Owner

simonw commented Oct 22, 2024

OK, that fixed it - thanks everyone.

@simonw simonw closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants