Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and some improvements #7

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Conversation

Bai-Chiang
Copy link
Contributor

  • Add libxcrypt1 to libactpol and pixell linux build.
    Fix missing libcrypt.so.1 error.
    libcrypt.so.1 is no longer available from some distributions conda-forge/perl-feedstock#56 (comment)
  • Remove extra quotes in pkgs/so3g/meta.yaml script_env field.
    The extra quotes cause conda-build generate build_env_setup.sh with

    export CFLAGS=""-Wno-error -O3 -g -fPIC""
    export CXXFLAGS=""-Wno-error -O3 -g -fPIC -std=c++14""
    and failed to build package.

  • Add conda-verify package.
    Remove WARNING message.

    WARNING: Importing conda-verify failed. Please be sure to test your packages. conda install conda-verify to make this message go away.

  • Add nodefaults channel to new environment.
    This will ignore channels listed in default ~/.condarc
  • Add conda-libmamba-solver package add use libmamba solver in new
    environment.
    This will speed up build process when trying to solve dependencies.
  • soconda.sh When specifing ${base} should skip getting conda_dir from conda command.
  • soconda.sh use -z compare length of string.

- use -z compare length of string.
- Specifing ${base} should skip getting conda_dir from conda command.
- Add libxcrypt1 to libactpol and pixell linux build.
  Fix missing libcrypt.so.1 error.
- Remove extra quotes in pkgs/so3g/meta.yaml script_env field.
  It cause so3g package fail to build.
- Add conda-verify package.
  Remove WARNING message.
- Add nodefaults channel to new environment.
  This will ignore channels listed in default ~/.condarc
- Add conda-libmamba-solver package add use libmamba solver in new
  environment.
  This will speed up build process when trying to solve dependencies.
Copy link
Member

@tskisner tskisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine, but can you confirm that the libmamba solver in a non-base environment will get used?

packages_conda.txt Show resolved Hide resolved
soconda.sh Show resolved Hide resolved
soconda.sh Show resolved Hide resolved
This was referenced Oct 17, 2023
@tskisner tskisner merged commit 33463b7 into simonsobs:main Oct 18, 2023
@Bai-Chiang Bai-Chiang deleted the small-fixes branch March 4, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants