Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.1 + pnpm = @responsive-image/ember is missing its addon main file #1043

Closed
MichalBryxi opened this issue Feb 12, 2025 · 2 comments · Fixed by #1044
Closed

v1.0.1 + pnpm = @responsive-image/ember is missing its addon main file #1043

MichalBryxi opened this issue Feb 12, 2025 · 2 comments · Fixed by #1044
Labels

Comments

@MichalBryxi
Copy link
Contributor

MichalBryxi commented Feb 12, 2025

Having following in package.json:

  "dependencies": {
    "@responsive-image/ember": "1.0.1",
    "@responsive-image/webpack": "1.0.1",
  }

And using:

node --version
v23.7.0

pnpm --version
9.14.2

I get following error when running the app:

pnpm start

...

Done in 2s

> [email protected] start /Users/michal/hefr.ch/ass-4.2/ass-4.2-ui
> ember serve

@responsive-image/ember at /Users/michal/hefr.ch/ass-4.2/ass-4.2-ui/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@[email protected]_6yyp4qd6zrfp5xvmrwt6k7jslm/node_modules/@responsive-image/ember is missing its addon main file


Stack Trace and Error Report: /var/folders/8q/yrjx_8s115q43r8w5qd90_m00000gn/T/error.dump.6caec4d68a069d2ba6a35c72693159d2.log
 ELIFECYCLE  Command failed with exit code 1.

When I downgrade to following version, everything is ok:

  "dependencies": {
    "@responsive-image/ember": "1.0.0",
    "@responsive-image/webpack": "1.0.0",
  }

And looking at what's released, I don't think it's incorrect error:

  • v1.0.0 - the file addon-main.js is present
  • v1.0.1 - the file addon-main.js is missing
@simonihmig
Copy link
Owner

Oh sh*t, I messed this up here: #866. Renamed addon-main.js to addon-main.cjs, without updating package.json#files here. 🤦‍♂️

That's the kind of stuff that you won't catch in CI before publishing the package.

Thanks for reporting @MichalBryxi , this should fix this: #1044. Will get this released tomorrow!

And thanks for being an early adopter here! :) Curious, can I see you work, is it open-source?

@simonihmig
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants