Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#87 Fix issues regarding whitespaces and different file separators in ssh-key file path #106

Merged
merged 13 commits into from
Jan 28, 2025

Conversation

simonhauck
Copy link
Owner

@simonhauck simonhauck commented Jan 25, 2025

Fix issues regarding whitespaces in ssh-key file path
Correctly escape paths with a \ on windows

- On linux these tests run successfully. Maybe this is an OS dependant problem?
@simonhauck simonhauck linked an issue Jan 25, 2025 that may be closed by this pull request
github-actions[bot]
github-actions bot previously approved these changes Jan 25, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 26, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 28, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 28, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 28, 2025
@simonhauck simonhauck marked this pull request as ready for review January 28, 2025 20:23
github-actions[bot]
github-actions bot previously approved these changes Jan 28, 2025
@simonhauck simonhauck force-pushed the 87-ssh-key-file-path-with-whitespaces-does-not-work branch from f0abd28 to e32e2fa Compare January 28, 2025 21:31
@simonhauck simonhauck changed the title #87 add test to verify bug #87 Fix issues regarding whitespaces and different file separators in ssh-key file path Jan 28, 2025
@simonhauck simonhauck enabled auto-merge January 28, 2025 21:34
@simonhauck simonhauck merged commit 869df20 into main Jan 28, 2025
4 checks passed
@simonhauck simonhauck deleted the 87-ssh-key-file-path-with-whitespaces-does-not-work branch January 28, 2025 21:40
@simonhauck simonhauck added the bug Something isn't working label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH key file path with whitespaces does not work
1 participant