Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When delayBeforePush is set, the delay is shorter than expected #53

Closed
WeisSeb opened this issue Jun 6, 2024 · 0 comments
Closed

When delayBeforePush is set, the delay is shorter than expected #53

WeisSeb opened this issue Jun 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@WeisSeb
Copy link
Contributor

WeisSeb commented Jun 6, 2024

Describe the bug

When setting delayBeforePush the delay between pushes is around 1000 times shorter than the provided value

Current behavior

With

release {
    delayBeforePush = 1.minutes.toJavaDuration()
}

There are around 60ms between pushes.

Expected behavior

There should be 1 minute (60,000ms) between pushes

Possible cause

This seems to be the culprit. The delay is provided to Thread.sleep() in seconds. Thread.sleep() however expects the provided value to be milliseconds

📱 Tech info

  • Plugin version: 1.0.0-RC2
WeisSeb added a commit to WeisSeb/gradle-release-plugin that referenced this issue Jun 6, 2024
@simonhauck simonhauck added the bug Something isn't working label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants