Warn on duplicate autoIncrement columns (#3130)

simolus3 · Aug 4, 2024 · 24905dc · 24905dc
1 parent ceeae72
commit 24905dc
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/drift_dev/lib/src/analysis/resolver/dart/table.dart b/drift_dev/lib/src/analysis/resolver/dart/table.dart
@@ -73,14 +73,24 @@ class DartTableResolver extends LocalElementResolver<DiscoveredDartTable> {
       ],
     );
 
-    if (primaryKey != null &&
-        columns.any((c) => c.constraints.any((e) => e is PrimaryKeyColumn))) {
+    final columnsWithPrimaryKeyConstraint = columns
+        .where((c) => c.constraints.any((e) => e is PrimaryKeyColumn))
+        .length;
+    if (primaryKey != null && columnsWithPrimaryKeyConstraint > 0) {
       reportError(DriftAnalysisError.forDartElement(
         element,
         "Tables can't override primaryKey and use autoIncrement()",
       ));
     }
 
+    if (columnsWithPrimaryKeyConstraint > 1) {
+      reportError(DriftAnalysisError.forDartElement(
+        element,
+        'More than one column uses autoIncrement(). This would require '
+        'multiple primary keys, which is not supported.',
+      ));
+    }
+
     if (primaryKey != null &&
         primaryKey.length == 1 &&
         primaryKey.first.constraints.contains(const UniqueColumn())) {

diff --git a/drift_dev/test/analysis/resolver/dart/table_parser_test.dart b/drift_dev/test/analysis/resolver/dart/table_parser_test.dart
@@ -325,4 +325,24 @@ void main() {
       ]),
     );
   });
+
+  test('warns about tables with two autoIncrement columns', () async {
+    final backend = await TestBackend.inTest({
+      'a|lib/a.dart': '''
+import 'package:drift/drift.dart';
+
+class MyAwesomeTable extends Table {
+  IntColumn get id => integer().autoIncrement()();
+  TextColumn get title => text().withLength(min: 1, max: 32)();
+  TextColumn get description => text()();
+  IntColumn get sortOrder => integer().autoIncrement()();
+}
+'''
+    });
+
+    final file = await backend.analyze('package:a/a.dart');
+
+    expect(file.allErrors,
+        [isDriftError(contains('More than one column uses autoIncrement()'))]);
+  });
 }