test: remove ->expects(self::any()) #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: remove ->expects(self::any())
| Q | A |------------- | ----------- | Type | improvement | Fixed issues | <!-- use #NUM format to reference an issue --> #### Summary _This is a followup of https://github.com/doctrine/dbal/pull/6558_, I have touched only what previous PR touched. @greg0ire [requested](doctrine#6562 (review)) to use stubs where there are no expectations 
Cover scenario `BEGIN TRANSACTION; COMMIT; BEGIN TRANSACTION; --failure`
<!-- Fill in the relevant information below to help triage your pull request. --> | Q | A |------------- | ----------- | Type | improvement | Fixed issues | <!-- use #NUM format to reference an issue --> #### Summary Run CI tests against Postgres 17.
…octrine#6563) | Q | A |------------- | ----------- | Type | improvement | Fixed issues | <!-- use #NUM format to reference an issue --> #### Summary Covers the concern expressed by @greg0ire doctrine#6545 (comment) This ensures the transaction is (not)active based on `autocommmit` mode when interacting with `transactional()`.
… transaction Let's get rid of There's no active transaction exception which occurs e.g. when using deferred constraints so the violation is checked at the end of the transaction and not during it. - Do not rollback only on exceptions where we know the transaction is no longer active - Introduce TransactionRolledBack exception - Transform Oracle's "transaction rolled back" exception and use the underlying one that DBAL supports
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.9.x #13 +/- ##
==========================================
+ Coverage 85.90% 85.95% +0.04%
==========================================
Files 277 277
Lines 17049 17077 +28
==========================================
+ Hits 14646 14678 +32
+ Misses 2403 2399 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…6563)
Summary
Covers the concern expressed by @greg0ire
doctrine#6545 (comment)
This ensures the transaction is (not)active based on
autocommmitmodewhen interacting with
transactional().Summary
… transaction
Let's get rid of There's no active transaction exception which occurs e.g. when using deferred constraints so the violation is checked at the end of the transaction and not during it.