Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

Add runtime dependency on neo4j Python package #11

Closed
jnturton opened this issue May 11, 2020 · 4 comments
Closed

Add runtime dependency on neo4j Python package #11

jnturton opened this issue May 11, 2020 · 4 comments

Comments

@jnturton
Copy link

I think the README should tell users that we will need the Python Neo4j driver.

https://pypi.org/project/neo4j/

pip3 install neo4j

@sim51
Copy link
Owner

sim51 commented May 11, 2020

Thanks for the feedback !.

In fact this module has two dependencies : neo4j driver & python-dateutil
https://github.com/sim51/neo4j-fdw/blob/master/setup.py#L11

Normally those deps are installed when you call python setup.py install as described in the doc (or with make install). No ?

But I see that neo4j-driver is deprecated in favor of just neo4j (just a rename of the lib name)

Installation from the neo4j-driver package on PyPI is now deprecated and will be discontinued in the 2.x series driver releases. Please install from the neo4j package instead.

I will change that.

@jnturton
Copy link
Author

jnturton commented May 11, 2020

Ah, okay. My installation procedure was a bit different and went

apt install postgresql-12-python3-multicorn
pgxn install neo4j-fdw

After that I had to figure out that the neo4j Python package was missing.

@sim51
Copy link
Owner

sim51 commented May 11, 2020

Ho cool, this is my first feedback on the pgxn package.

I will check if it's possible to package the deps directly in pgxn, otherwise I update the doc.

Thanks !

sim51 added a commit that referenced this issue Jul 24, 2020
@sim51
Copy link
Owner

sim51 commented Jul 24, 2020

After checking, PGXN is calling "make & make install" that pretty much do a python ./setup.py install. So the deps are installed by PGXN.
I added a note in the readme.

@sim51 sim51 closed this as completed Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants