-
Notifications
You must be signed in to change notification settings - Fork 18
WIP: initial pure js impl for IBM i AIX variant #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@patrickhrastnik , please review. Thanks! |
Sorry, this is still a WIP for reason initially stated. This was my first time trying GitHub's new "Draft PR" function, and apparently saying it's "ready for review" makes it no longer a draft. Sorry about that! |
This is much better. So I take it |
Changes approved, works as expected on our IBM i
|
Correct. This only works for the IBM i variant and not for the mainline AIX.
|
Merged and did a few minor tweaks in 4ac57d4. Would you mind giving latest master one more test before I release it? |
Testing looks good to me. Thanks! |
Creating as draft because the necessary
db2util
command has not yet been officially delivered by IBM. Hoping to address concerns in issues #5/#10.The exception cases result in a UnhandledPromiseRejectionWarning but that seems in line with other implementations.
Review is welcome and appreciated