FIX Allow setMaxLength for all field types (TextField, TextareaField)

silverstripe · Feb 8, 2025 · c8eff3e · c8eff3e
1 parent 5b71b31
commit c8eff3e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/code/Model/EditableFormField/EditableTextField.php b/code/Model/EditableFormField/EditableTextField.php
@@ -185,9 +185,7 @@ protected function updateFormField($field)
         }
 
         if (is_numeric($this->MaxLength) && $this->MaxLength > 0) {
-            if ($field instanceof TextField) {
-                $field->setMaxLength((int) $this->MaxLength);
-            }
+            $field->setMaxLength((int) $this->MaxLength);
             $field->setAttribute('data-rule-maxlength', (int) $this->MaxLength);
         }
 

diff --git a/tests/php/Model/EditableFormFieldTest.php b/tests/php/Model/EditableFormFieldTest.php
@@ -232,7 +232,7 @@ public function testLengthRange()
         // textarea
         $textField->Rows = 3;
         $attributes = $textField->getFormField()->getAttributes();
-        $this->assertFalse(isset($attributes['maxLength']));
+        $this->assertEquals(20, $attributes['maxlength']);
         $this->assertEquals(10, $attributes['data-rule-minlength']);
         $this->assertEquals(20, $attributes['data-rule-maxlength']);
     }