Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Define deactivate() on SudoModeServiceInterface #11618

Merged
merged 1 commit into from
Feb 20, 2025
Merged

API Define deactivate() on SudoModeServiceInterface #11618

merged 1 commit into from
Feb 20, 2025

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Feb 20, 2025 •
edited
Loading

Issue silverstripe/silverstripe-admin#1898

Broken tests are unrelated and will be fixed in #11619

@emteknetnz emteknetnz mentioned this pull request Feb 20, 2025
Closed
5 tasks
@emteknetnz emteknetnz marked this pull request as ready for review February 20, 2025 02:37
@emteknetnz emteknetnz mentioned this pull request Feb 20, 2025
Merged
GuySartorelli
GuySartorelli approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 6f021af into silverstripe:6.0 Feb 20, 2025
8 of 14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6.0/sudo-int branch February 20, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli