FIX Respect SS_BASE_URL scheme in CLI environment #10616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkleiner
changed the title
GuySartorelli
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
This seems okay to me - I notice some discussion about the host in the issue, but it seems like the host is already being set correctly and any change to the way that's handled could be an additional enhancement if we discover that it would be useful.
This PR does seem to resolve a genuine issue in and off itself.
I'd like another pair of eyes over this before merging @silverstripe/core-team
Also, this should probably target the 4.12 branch so that it can be released in a patch release rather than waiting for the 4.13 minor release.
dhensby
approved these changes
Dec 19, 2022
Additionally set _SERVER variables for HTTPS and SSL to respect SS_BASE_URL scheme when executing builds and tasks through CLI. This should solve base tags not being provided with the correct HTTP scheme. This is important to resolve mixed content issues and insecure requests.
GuySartorelli
force-pushed
the
10615-Respect-SS_BASE_URL-for-CLI-RequestBuilder
branch
from
da18ce7 to
4a1eb0c
Compare
|
I've changed the base of this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally set _SERVER variables for HTTPS and SSL to respect SS_BASE_URL scheme when executing builds and tasks through CLI. This should solve base tags not being provided with the correct HTTP scheme. This is important to resolve mixed content issues and insecure requests.
Parent issue