Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Form sudo mode #684

Merged
merged 1 commit into from
Feb 20, 2025
Merged

DOC Form sudo mode #684

merged 1 commit into from
Feb 20, 2025

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Feb 10, 2025 •
edited
Loading

@emteknetnz emteknetnz mentioned this pull request Feb 10, 2025
Closed
5 tasks
@emteknetnz emteknetnz force-pushed the pulls/5/form-sudo-mode branch 2 times, most recently from 00a0c54 to 4b3710d Compare February 11, 2025 02:05
@emteknetnz emteknetnz marked this pull request as ready for review February 11, 2025 22:27
GuySartorelli
GuySartorelli requested changes Feb 13, 2025
View reviewed changes
@emteknetnz emteknetnz force-pushed the pulls/5/form-sudo-mode branch 2 times, most recently from 8f251f2 to 8e23e6a Compare February 17, 2025 05:16
GuySartorelli
GuySartorelli requested changes Feb 17, 2025
View reviewed changes
@GuySartorelli GuySartorelli mentioned this pull request Feb 17, 2025
Merged
@emteknetnz emteknetnz force-pushed the pulls/5/form-sudo-mode branch from 8e23e6a to f2062bf Compare February 18, 2025 02:43
@GuySartorelli
Copy link
Member

There's a merge conflict to resolve here

@emteknetnz emteknetnz force-pushed the pulls/5/form-sudo-mode branch 3 times, most recently from b21cc61 to 3209462 Compare February 19, 2025 01:57
GuySartorelli
GuySartorelli requested changes Feb 19, 2025
View reviewed changes
@emteknetnz emteknetnz force-pushed the pulls/5/form-sudo-mode branch from 3209462 to 766186f Compare February 19, 2025 04:58
@emteknetnz
Copy link
Member Author

Need to add a note that any end-to-end tests editing

Done

GuySartorelli
GuySartorelli approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 1d582bb into silverstripe:5 Feb 20, 2025
2 of 3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/form-sudo-mode branch February 20, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli