Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Move i18n::default_locale value in to config.yml #126

Merged
merged 1 commit into from
Sep 20, 2023
Merged

MNT Move i18n::default_locale value in to config.yml #126

merged 1 commit into from
Sep 20, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova force-pushed the pulls/3/update-cwp-locale-settings branch from f332b46 to 2ff1907 Compare September 20, 2023 02:59
@sabina-talipova sabina-talipova mentioned this pull request Sep 20, 2023
Closed
GuySartorelli
GuySartorelli approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. I couldn't find any regressions this would cause in my checks.

@GuySartorelli GuySartorelli merged commit 3ff115b into silverstripe:3 Sep 20, 2023
@GuySartorelli GuySartorelli deleted the pulls/3/update-cwp-locale-settings branch September 20, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli