Skip to content

Commit

Permalink
remove LOC on forEach loops
Browse files Browse the repository at this point in the history
Signed-off-by: Federico Silva <[email protected]>
  • Loading branch information
silvaf-dev committed Jan 6, 2025
1 parent 57a03d1 commit 39ec9e6
Showing 1 changed file with 4 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,13 @@ const addSidebarFieldsAndCheckDocTableColumns = (
return cy.getElementByTestId('docTableHeaderField').eq(index);
};
const checkTableHeadersByArr = (expectedHeaders) => {
let currentHeader = 1;
expectedHeaders.forEach((header) => {
getDocTableHeaderByIndex(currentHeader).should('have.text', header);
currentHeader++;
expectedHeaders.forEach((header, currentHeader) => {
getDocTableHeaderByIndex(++currentHeader).should('have.text', header);
});
};
const checkDocTableColumnByArr = (expectedValues, columnNumber) => {
let currentRow = 0;
expectedValues.forEach((value) => {
expectedValues.forEach((value, currentRow) => {
dataExplorer.getDocTableField(columnNumber, currentRow).should('have.text', value);
currentRow++;
});
};
const selectFields = (testFields) => {
Expand Down Expand Up @@ -251,12 +247,7 @@ describe('sidebar spec', () => {
const testFields = ['service_endpoint', 'response_time', 'bytes_transferred', 'request_url'];
const expectedTimeValues = ['3.32', '2.8', '3.35', '1.68', '4.98'];
it('add field in index pattern', () => {
addSidebarFieldsAndCheckDocTableColumns(
testFields,
expectedTimeValues,
pplQuery,
sqlQuery
);
addSidebarFieldsAndCheckDocTableColumns(testFields, expectedTimeValues, pplQuery, sqlQuery);
});
it('add field in index', () => {
addSidebarFieldsAndCheckDocTableColumns(testFields, expectedTimeValues, pplQuery, sqlQuery, false);
Expand Down

0 comments on commit 39ec9e6

Please sign in to comment.