Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild/Republish products from UI #1067

Open
wants to merge 41 commits into
base: feature/svelte
Choose a base branch
from

Conversation

FyreByrd
Copy link

@FyreByrd FyreByrd commented Feb 3, 2025

  • Expanded StartupWorkflow to also include rebuild and republish
  • Fixed a few issues stemming from deleting workflow instances
  • Added UI for rebuilding/republishing products

Notes:

  • This does NOT implement automatic rebuild (we can talk about adding that to this PR)
  • I currently have it so that bulk rebuild will ignore products in the backend that can't be rebuilt. Not sure if this is the desired behavior. However, since the frontend has the same constraints, it shouldn't be an issue.

Bulk Modal:

image

Individual product menu:

image

@FyreByrd FyreByrd requested a review from chrisvire February 3, 2025 16:01
@FyreByrd
Copy link
Author

FyreByrd commented Feb 3, 2025

I did make some changes from how the bulk rebuild modal is handled in S1.
The modal in S1 simply displays a list of all product definitions that are in the selected projects with no breakdown by project, no indication if a product definition has either rebuild or republish available, and no regard for if the product can be rebuilt.

S1 with no products selected:
image

S1 with an invalid selection:
image

In contrast, the implementation I currently have for S2 groups the product definitions by project, shows whether a product has a rebuild or republish workflow defined, and only displays products that are actually able to be rebuilt/republished.

S2 with no products selected:
image

S2 with an invalid selection: not possible

The way I currently have it implemented, a product will only be displayed for rebuild in the modal if all of the following are true:

  1. The product has been published (i.e. Product.DatePublished is not null). This filters out products that have been terminated.
  2. The product does not have a Workflow Instance.
  3. The product definition has either a Rebuild Workflow or a Republish Workflow

@FyreByrd FyreByrd force-pushed the feature/rebuild-workflows branch from 56f7798 to fabf929 Compare February 11, 2025 16:32
@FyreByrd
Copy link
Author

Hooray for merge conflicts...

FyreByrd and others added 7 commits February 11, 2025 11:34
`request` would return error if a system was marked as unavailable.
In the system status check job, systems were initialized to be marked unavailable. This meant that systems would never be successfully updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants