Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MergeDups] Toast when actions fail #3607

Merged
merged 3 commits into from
Feb 12, 2025
Merged

[MergeDups] Toast when actions fail #3607

merged 3 commits into from
Feb 12, 2025

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 7, 2025

Resolves #2099


This change is Reviewable

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.35%. Comparing base (195323a) to head (47f8a1d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...geDuplicates/MergeDupsStep/MergeDragDrop/index.tsx 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3607      +/-   ##
==========================================
- Coverage   74.40%   74.35%   -0.05%     
==========================================
  Files         285      285              
  Lines       11042    11049       +7     
  Branches     1348     1350       +2     
==========================================
  Hits         8216     8216              
- Misses       2438     2445       +7     
  Partials      388      388              
Flag Coverage Δ
backend 83.72% <ø> (ø)
frontend 66.12% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as draft February 12, 2025 19:03
@imnasnainaec imnasnainaec marked this pull request as ready for review February 12, 2025 19:22
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 5dfb1a1 into master Feb 12, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the merge-reasons branch February 12, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MergeDups] Improve ui for handling protected senses
2 participants