Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SiteSettings] Redesign project management #3565

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 31, 2025

Fixes #3552


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working enhancement New feature or request frontend performance labels Jan 31, 2025
@imnasnainaec imnasnainaec self-assigned this Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.40%. Comparing base (4612156) to head (4e1c250).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...omponents/SiteSettings/ProjectManagement/index.tsx 76.47% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3565      +/-   ##
==========================================
- Coverage   74.46%   74.40%   -0.06%     
==========================================
  Files         285      285              
  Lines       11030    11042      +12     
  Branches     1346     1348       +2     
==========================================
+ Hits         8213     8216       +3     
- Misses       2430     2438       +8     
- Partials      387      388       +1     
Flag Coverage Δ
backend 83.72% <ø> (-0.02%) ⬇️
frontend 66.20% <76.47%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec requested a review from andracc February 10, 2025 19:03
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 195323a into master Feb 11, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the site-settings-proj branch February 11, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request frontend performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SiteSettings] BIG delay checking every project if empty
2 participants