Merge pull request #69 from siisltd/feature/fix_smsc_sender

added delivery error
siisltd · Jun 14, 2024 · 8ccc9c8 · 8ccc9c8
2 parents 9a7d33e + fa58c47
commit 8ccc9c8
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 2 deletions.
diff --git a/src/Notifications/Curiosity.Notifications.SMS/CHANGELOG.md b/src/Notifications/Curiosity.Notifications.SMS/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## [1.4.1] 
+
+### Changed
+
+- Add delivery error
+
 ## [1.4.0] - 2023-01-29
 
 ### Changed

diff --git a/src/Notifications/Curiosity.Notifications.SMS/SmsNotificationChannel.cs b/src/Notifications/Curiosity.Notifications.SMS/SmsNotificationChannel.cs
@@ -74,6 +74,7 @@ protected override async Task ProcessNotificationAsync(SmsNotification notificat
                     2 => NotificationErrorCode.Communication,
                     4 => NotificationErrorCode.RateLimit,
                     5 => NotificationErrorCode.NoMoney,
+                    6 => NotificationErrorCode.DeliveryError,
                     _ => NotificationErrorCode.Unknown,
                 };
 

diff --git a/src/Notifications/Curiosity.Notifications/CHANGELOG.md b/src/Notifications/Curiosity.Notifications/CHANGELOG.md
@@ -1,11 +1,17 @@
 # Changelog
 
+## [1.3.1] 
+
+### Changed
+
+- Add delivery error
+
 ## [1.3.0] - 2023-01-29
 
 ### Changed
 
 - Upgraded `Microsoft`'s packages up to `6.*` versions.
-- 
+
 ## [1.2.4] - 2022-06-20
 
 ### Changed

diff --git a/src/Notifications/Curiosity.Notifications/Exceptions/NotificationErrorCode.cs b/src/Notifications/Curiosity.Notifications/Exceptions/NotificationErrorCode.cs
@@ -38,6 +38,11 @@ public enum NotificationErrorCode
         /// <summary>
         /// Send data was incorrect.
         /// </summary>
-        IncorrectRequestData = 6
+        IncorrectRequestData = 6,
+
+        /// <summary>
+        /// Delivery error
+        /// </summary>
+        DeliveryError = 7,
     }
 }