Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fulcio mock support for all GH claims #1319

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

bdehamer
Copy link
Collaborator

Updates the mock Fulcio server (in the @sigstore/mock package) to support mapping all of the GH OIDC claims to the proper extensions in the Fulcio-issued signing certificate.

@bdehamer bdehamer requested a review from a team as a code owner November 25, 2024 23:04
Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: ebab3d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sigstore/mock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Samuel Giddins <[email protected]>
Signed-off-by: Brian DeHamer <[email protected]>
@bdehamer bdehamer force-pushed the bdehamer/mock-server-gh-claims branch from cb45177 to ba1b853 Compare November 25, 2024 23:06
@bdehamer bdehamer changed the title fulcio mock support for all GH claims Fulcio mock support for all GH claims Nov 25, 2024
Copy link

@eugenejahn eugenejahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bdehamer bdehamer enabled auto-merge (squash) November 26, 2024 18:18
Copy link
Contributor

@ejahnGithub ejahnGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bdehamer bdehamer merged commit c2ca121 into main Nov 26, 2024
25 checks passed
@bdehamer bdehamer deleted the bdehamer/mock-server-gh-claims branch November 26, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants