-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Fulcio client lib and use LegacyClient #1760
Conversation
4be881a
to
b00c8e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think .fulcioverifier.go.swp
is unintended?
b00c8e5
to
71e85e4
Compare
Yup, removed and need a mod tidy as well |
71e85e4
to
0c2a8e6
Compare
Uses the LegacyClient as the GRPC change hasn't yet been deployed. Signed-off-by: Nathan Smith <[email protected]>
0c2a8e6
to
316683b
Compare
Hmm I see the GRPC refactor did pull in some banned dependencies (trillian + grpc middleware) that work against our slimming down the cosign binary.... Should we make a |
I removed |
Ah ok, yeah I don't think we can run away from depending on grpc either now so these changes make sense then.. |
I wonder if the issue is the same thing I was running into in #1731, where one of the Trillian packages defines a flag that conflicts with what's defined in cosignd. |
This is why in #1731 I copied in a file, so that when I used that package, I was only pulling in the bare minimum. |
closing in favour of #1762 |
Summary
With @bobcallaway's recent work the client in Fulcio library was renamed to LegacyClient. This change bumps the Fulcio package version and uses that new LegacyClient name. Once GRPC is rolled out in production we should move off of this client as it uses the v1 API's