-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POST /eth/v2/beacon/pool/attestations
bugfixes
#6867
Merged
mergify
merged 12 commits into
sigp:unstable
from
eserilev:post-attestations-v2-bugfixes
Jan 31, 2025
Merged
POST /eth/v2/beacon/pool/attestations
bugfixes
#6867
mergify
merged 12 commits into
sigp:unstable
from
eserilev:post-attestations-v2-bugfixes
Jan 31, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttestation, and accept strings for committee_index and attester_index fields
eserilev
added
bug
Something isn't working
ready-for-review
The code is ready for review
HTTP-API
electra
Required for the Electra/Prague fork
v6.1.0
New release c. Q1 2025
labels
Jan 26, 2025
eserilev
added
work-in-progress
PR is a work-in-progress
and removed
ready-for-review
The code is ready for review
labels
Jan 27, 2025
eserilev
added
ready-for-review
The code is ready for review
and removed
work-in-progress
PR is a work-in-progress
labels
Jan 27, 2025
michaelsproul
added
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
and removed
ready-for-review
The code is ready for review
labels
Jan 28, 2025
eserilev
added
ready-for-review
The code is ready for review
and removed
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
labels
Jan 29, 2025
michaelsproul
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one suggested change
michaelsproul
added
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
and removed
ready-for-review
The code is ready for review
labels
Jan 30, 2025
michaelsproul
approved these changes
Jan 30, 2025
michaelsproul
added
ready-for-merge
This PR is ready to merge.
and removed
waiting-on-author
The reviewer has suggested changes and awaits thier implementation.
labels
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
electra
Required for the Electra/Prague fork
HTTP-API
ready-for-merge
This PR is ready to merge.
v6.1.0
New release c. Q1 2025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6857
SingleAttestation
and pre-ElectraAttestation
SingleAttestation
fieldscommittee_index
andattester_index
now accept strings when deserializing from JSON