Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST /eth/v2/beacon/pool/attestations bugfixes #6867

Merged
merged 12 commits into from
Jan 31, 2025

Conversation

eserilev
Copy link
Collaborator

Closes #6857

  • The v2 endpoint can now accept both SingleAttestation and pre-Electra Attestation
  • SingleAttestation fields committee_index and attester_index now accept strings when deserializing from JSON

…ttestation, and accept strings for committee_index and attester_index fields
@eserilev eserilev added bug Something isn't working ready-for-review The code is ready for review HTTP-API electra Required for the Electra/Prague fork v6.1.0 New release c. Q1 2025 labels Jan 26, 2025
@eserilev eserilev requested a review from jxs as a code owner January 26, 2025 15:21
@eserilev eserilev added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Jan 27, 2025
@eserilev eserilev added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Jan 27, 2025
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 28, 2025
@michaelsproul michaelsproul mentioned this pull request Jan 28, 2025
2 tasks
@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 29, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one suggested change

beacon_node/http_api/src/lib.rs Outdated Show resolved Hide resolved
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 30, 2025
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 30, 2025
@mergify mergify bot merged commit 276eda3 into sigp:unstable Jan 31, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working electra Required for the Electra/Prague fork HTTP-API ready-for-merge This PR is ready to merge. v6.1.0 New release c. Q1 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants