Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc PeerDAS todos #6862

Merged
merged 14 commits into from
Feb 11, 2025
Merged

Fix misc PeerDAS todos #6862

merged 14 commits into from
Feb 11, 2025

Conversation

dapplion
Copy link
Collaborator

Issue Addressed

Address misc PeerDAS TODOs that are not too big for a dedicated PR

Proposed Changes

I'll justify each TODO on an inlined comment

@dapplion dapplion added work-in-progress PR is a work-in-progress das Data Availability Sampling labels Jan 24, 2025
@dapplion dapplion requested a review from jxs as a code owner January 24, 2025 19:18
@dapplion dapplion requested a review from jimmygchen January 24, 2025 19:19
@dapplion dapplion mentioned this pull request Jan 25, 2025
52 tasks
@dapplion dapplion added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Feb 3, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed, added some comments, otherwise looks good to merge soon.

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Feb 6, 2025
@dapplion dapplion requested a review from jimmygchen February 11, 2025 04:35
@dapplion dapplion added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 11, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for cleaning up the TODOs 🙏

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 11, 2025
mergify bot added a commit that referenced this pull request Feb 11, 2025
@mergify mergify bot merged commit 3992d6b into sigp:unstable Feb 11, 2025
31 checks passed
@dapplion dapplion deleted the peerdas-todos branch February 11, 2025 16:43
pawanjay176 pushed a commit to pawanjay176/lighthouse that referenced this pull request Feb 21, 2025
Address misc PeerDAS TODOs that are not too big for a dedicated PR


  I'll justify each TODO on an inlined comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants