Add builder SSZ flow #6859
Merged
Add builder SSZ flow #6859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
added
work-in-progress
eserilev
added
ready-for-review
michaelsproul
approved these changes
Feb 3, 2025
| @@ -4,6 +4,11 @@ use serde::{Deserialize, Deserializer, Serialize}; | |||
| use serde_json::value::Value; | |||
| use std::sync::Arc; | |||
|
|
|||
| pub trait ForkVersionDecode: Sized { | |||
There was a problem hiding this comment.
I like this. Nice improvement
|
I made a few tiny changes in this commit: Mostly just deleting a redundant |
michaelsproul
added
ready-for-merge
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6514
DecodeByForktrait. This is required for an axum extractor I introduced in this PRAtomicBoolfield on the builder client struct. When set to true, it indicates that SSZ is enabled for the builder. This flag is updated each time a response is received fromGET builder/header.