Add voluntary exit via validator manager #6612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chong-he
commented
Dec 23, 2024
michaelsproul
requested changes
Jan 22, 2025
| .value_name("NETWORK_ADDRESS") | ||
| .help("Address to a beacon node HTTP API") | ||
| .action(ArgAction::Set) | ||
| .display_order(0), |
There was a problem hiding this comment.
We could add a conflicts_with to make --beacon-node and --presign conflict? Users shouldn't be doing both.
There was a problem hiding this comment.
Also added conflicts_with for the flag --exit-epoch and --beacon-node, and that --exit-epoch will require --presign as I think having --exit-epoch alone isn't meaningful.
michaelsproul
added
waiting-on-author
chong-he
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
--exit-epochflag to validator-manager #4303Proposed Changes
-Add voluntary exit feature to the validator manager
-Add delete all validators by using the keyword "all"
Additional Info
I reuse some code from the
lighthouse account validator exitfile:https://github.com/sigp/lighthouse/blob/stable/account_manager/src/validator/exit.rs
Thank you @michaelsproul for the help and guidance along the way