Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking unstable (a0a62ea) and #6156 together #6482

Closed
wants to merge 7 commits into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 11, 2024

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch unstable (a0a62ea) and #6156 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #6156.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue default for merge:

  • check-success=local-testnet-success
  • check-success=test-suite-success

Required conditions to stay in the queue:

---
previous_failed_batches: []
pull_requests:
  - number: 6156
...

jxs and others added 7 commits July 23, 2024 23:46
and remove connection limits checks after connection has been established,

as those checks have already been done by connection limits Behaviour.
when we call dial_peer we are not yet dialing but just adding the peer to the dial queue
we only use it at one place, and the function call is explicit.
but do it before the connection has been established.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jxs
❌ mergify[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@mergify mergify bot closed this Oct 11, 2024
@mergify mergify bot deleted the mergify/merge-queue/523aa4f079 branch October 11, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants