Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade gossipsub duplicate logs #5163

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Downgrade gossipsub duplicate logs #5163

merged 4 commits into from
Feb 6, 2024

Conversation

AgeManning
Copy link
Member

@AgeManning AgeManning commented Jan 31, 2024 •
edited
Loading

This undoes parts of #5009

We are getting a few more reports of seeing these warnings. Mostly because of people using fallback BNs.

I think the CLI flag approach is probably not necessary. I think most users know if they see these warnings are not going to expect that they are running multiple VC's in a slashable way, rather that they have fallback bns and probably won't react to the warning anyway.

I am proposing to downgrade these logs by default and simply remove the cli flag.

Wondering what @jimmygchen and @michaelsproul think about this.

@AgeManning AgeManning added the ready-for-review The code is ready for review label Jan 31, 2024
@jimmygchen
Copy link
Member

Sounds good to me! I didn't quite like this CLI flag to just disable a log warning anyway, so if we're ok to downgrade this log I'm happy to remove it. I think we might want to deprecate it for the time being though, as it's already been released? Although this flag is very new so we could just delete it if it doesn't impact people too much?

michaelsproul
michaelsproul approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call making it mandatory + default. Even when I saw the user reports of this log, I'd totally forgotten about the flag 🤦‍♂️

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Feb 2, 2024
@AgeManning
Copy link
Member Author

Agreed. I've made this PR backwards compatible.

We are getting a few deprecated flags building up. Perhaps next major release, we remove all the deprecated flags.

@michaelsproul
Copy link
Member

Perhaps next major release, we remove all the deprecated flags.

I think we can even do it in a minor release. We killed a bunch already in 4.6 with:

michaelsproul
michaelsproul approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test could have stayed without the assertion but I don't think it's worth blocking the merge on. LGTM

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 5, 2024
@realbigsean
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link

mergify bot commented Feb 5, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@realbigsean
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Feb 5, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Pull request #5163 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Feb 5, 2024
@mergify
Merge of #5163
f776485
This was referenced Feb 5, 2024
Closed
Merged
Merged
@michaelsproul michaelsproul mentioned this pull request Feb 5, 2024
Closed
@michaelsproul
Copy link
Member

Opened an issue for some other logs we could also target in this PR (or a follow-up if it merges before then). Would like your input @AgeManning on what you think is most reasonable here:

@jimmygchen
Copy link
Member

Looks like the CLI doc needs an update:

./book/src/help_bn.md has been updated

Going to unqueue this so other PRs can get in.

@jimmygchen
Copy link
Member

@mergify unqueue

@mergify Mergify
Copy link

mergify bot commented Feb 6, 2024

unqueue

✅ The pull request has been removed from the queue default

@jimmygchen
Copy link
Member

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Feb 6, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@jimmygchen
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Feb 6, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Feb 6, 2024
@mergify
Merge of #5163
ba8fa72
This was referenced Feb 6, 2024
Closed
Merged
Merged
mergify bot added a commit that referenced this pull request Feb 6, 2024
@mergify
Merge of #5163
1e74f6d
@mergify mergify bot mentioned this pull request Feb 6, 2024
Closed
5 tasks
@michaelsproul
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link

mergify bot commented Feb 6, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Feb 6, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8530427

mergify bot added a commit that referenced this pull request Feb 6, 2024
@mergify
Merge of #5163
0a720fc
This was referenced Feb 6, 2024
Closed
Merged
@mergify mergify bot merged commit 8530427 into sigp:unstable Feb 6, 2024
18 of 30 checks passed
@JamesCropcho JamesCropcho mentioned this pull request Feb 9, 2024
Closed
danielrachi1 pushed a commit to danielrachi1/lighthouse that referenced this pull request Feb 14, 2024
@AgeManning @danielrachi1
Downgrade gossipsub duplicate logs (sigp#5163)
627d9ed 
* Downgrade duplicate publish logs

* Maintain backwards compatiblity, deprecate flag

* The tests had to go, because there's no config to test against

* Update help_bn.md
@jimmygchen jimmygchen added the backwards-incompat Backwards-incompatible API change label Feb 21, 2024
@chenrui333 chenrui333 mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
backwards-incompat Backwards-incompatible API change ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AgeManning @jimmygchen @michaelsproul @realbigsean