Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Shutdown after sync #2519

Closed
wants to merge 3 commits into from

Conversation

pawanjay176
Copy link
Member

Issue Addressed

Resolves #2033

Proposed Changes

Adds a flag to enable shutting down beacon node right after sync is completed.

Additional Info

Will need modification after weak subjectivity sync is enabled to change definition of a fully synced node.

@pawanjay176 pawanjay176 requested a review from paulhauner August 17, 2021 15:37
@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Aug 17, 2021
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Re-running tests as windows failed.

@paulhauner paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Aug 20, 2021
@pawanjay176 pawanjay176 added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 24, 2021
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! There's a cargo-audit fail in CI but I think that's been fixed in unstable, therefore bors should work.

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 30, 2021
@bors
Copy link

bors bot commented Aug 30, 2021

Merge conflict.

@paulhauner
Copy link
Member

paulhauner commented Aug 30, 2021

Sorry @pawanjay176, looks like there's been a new merge conflict introduced :(

@paulhauner paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Aug 30, 2021
@pawanjay176
Copy link
Member Author

Fixed @paulhauner

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 30, 2021
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 30, 2021
## Issue Addressed

Resolves #2033 

## Proposed Changes

Adds a flag to enable shutting down beacon node right after sync is completed.

## Additional Info

Will need modification after weak subjectivity sync is enabled to change definition of a fully synced node.
@bors bors bot changed the title Shutdown after sync [Merged by Bors] - Shutdown after sync Aug 30, 2021
@bors bors bot closed this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants