[Merged by Bors] - Quote integers in sync committee contributions #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
|
Script for checking the fix (pardon my #!/usr/bin/env fish
set -x head_block (curl "http://localhost:5052/eth/v1/beacon/blocks/head")
set -x slot (math (echo $head_block | jq ".data.message.slot | tonumber") - 1)
set -x root (echo $head_block | jq .data.message.parent_root | string unescape)
curl -v "http://localhost:5052/eth/v1/validator/sync_committee_contribution?slot=$slot&subcommittee_index=0&beacon_block_root=$root"Response now looks like this: {
"data": {
"slot": "39314",
"beacon_block_root": "0x1db7ec90d59c37bb5bf7b3a59d4bf08fbdbc3afc8ca09c2205310436a4dd8e21",
"subcommittee_index": "0",
"aggregation_bits": "0x1b6ef9d9ffe6fbf5bf5f867f4fb79ffb",
"signature": "0xaf8a20f6df3a7105ada47d90315de3fe5a0fa436ed730189e36e553f3d46c7f26a4fc364e79c543cd93df1e17ba799f10080df46e1d72640747b9ff2316baefd6c84d2980d795dbd52cbd828ec8ba7a4c58015ee2ef58839d554c4abb8967a8b"
}
|
michaelsproul
changed the title
|
Thank you! bors r+ |
michaelsproul
added
ready-for-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2021
## Issue Addressed Closes #2514 ## Additional Info I've verified that the API now behaves correctly on altair-devnet-3
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
pawanjay176
pushed a commit
to pawanjay176/lighthouse
that referenced
this pull request
Aug 27, 2021
## Issue Addressed Closes sigp#2514 ## Additional Info I've verified that the API now behaves correctly on altair-devnet-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #2514
Additional Info
I've verified that the API now behaves correctly on altair-devnet-3