[Merged by Bors] - Fix starting-epoch check in doppelganger #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
added
bug
paulhauner
added
ready-for-review
realbigsean
reviewed
Aug 3, 2021
| @@ -540,7 +540,7 @@ impl DoppelgangerService { | |||
| continue; | |||
| }; | |||
|
|
|||
| if response.is_live && next_check_epoch >= response.epoch { | |||
There was a problem hiding this comment.
Dang bummed we missed this one :/
But thanks for the save @michaelsproul !
paulhauner
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
## Issue Addressed NA ## Proposed Changes Fixes a bug in Doppelganger Protection which would cause false-positives when a VC is restarted in the same epoch where it has already produced a signed message. It could also cause a false-negative in the scenario where time skips forward (perhaps due to host suspend/wake). The new `time_skips_forward_with_doppelgangers` test covers this case. This was a simple (and embarrassing, on my behalf) `>=` instead of `<=` bug that was missed by my tests but detected during manual testing by @michaelsproul (:pray:). Regression tests have been added. ## Additional Info NA ## TODO - [x] Add test for doppelganger in epoch > next_check_epoch
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Fixes a bug in Doppelganger Protection which would cause false-positives when a VC is restarted in the same epoch where it has already produced a signed message.
It could also cause a false-negative in the scenario where time skips forward (perhaps due to host suspend/wake). The new
time_skips_forward_with_doppelgangerstest covers this case.This was a simple (and embarrassing, on my behalf)
>=instead of<=bug that was missed by my tests but detected during manual testing by @michaelsproul (:pray:). Regression tests have been added.Additional Info
NA
TODO