Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Validator monitor support for sync committees #2476

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - Validator monitor support for sync committees #2476

wants to merge 15 commits into from

Conversation

pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

Add functionality in the validator monitor to provide sync committee related metrics for monitored validators.

@paulhauner paulhauner added the work-in-progress PR is a work-in-progress label Jul 22, 2021
@pawanjay176 pawanjay176 added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Jul 27, 2021
@abharti660
Copy link

I all review complete

@pawanjay176 pawanjay176 added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Jul 27, 2021
@pawanjay176 pawanjay176 added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Jul 29, 2021
@pawanjay176 pawanjay176 marked this pull request as ready for review July 29, 2021 10:25
@paulhauner paulhauner added the v1.5.1 To be included in the v1.5.1 relase label Aug 2, 2021
@michaelsproul michaelsproul changed the base branch from altair-vc to unstable August 6, 2021 08:23
@michaelsproul
Copy link
Member

Sorry @pawanjay176, created a bit of a mess changing the base to unstable. A rebase/merge will sort it out

realbigsean
realbigsean requested changes Aug 10, 2021
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left some comments, nothing major

beacon_node/beacon_chain/src/metrics.rs Outdated Show resolved Hide resolved
beacon_node/beacon_chain/src/validator_monitor.rs Outdated Show resolved Hide resolved
beacon_node/beacon_chain/src/validator_monitor.rs Outdated Show resolved Hide resolved
beacon_node/beacon_chain/src/beacon_chain.rs Outdated Show resolved Hide resolved
beacon_node/beacon_chain/src/validator_monitor.rs Outdated Show resolved Hide resolved
beacon_node/network/Cargo.toml Outdated Show resolved Hide resolved
beacon_node/network/src/beacon_processor/mod.rs Outdated Show resolved Hide resolved
beacon_node/network/src/beacon_processor/worker/gossip_methods.rs Show resolved Hide resolved
consensus/types/src/chain_spec.rs Outdated Show resolved Hide resolved
@realbigsean realbigsean added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Aug 10, 2021
@pawanjay176 pawanjay176 added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 11, 2021
realbigsean
realbigsean approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. v1.5.1 To be included in the v1.5.1 relase v1.5.2 The release after v1.5.1 and removed v1.5.1 To be included in the v1.5.1 relase ready-for-review The code is ready for review labels Aug 26, 2021
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 31, 2021
michaelsproul
michaelsproul approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelsproul
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Aug 31, 2021

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

bors bot pushed a commit that referenced this pull request Aug 31, 2021
@pawanjay176 @michaelsproul
Validator monitor support for sync committees (#2476)
5a3bcd2 
## Issue Addressed

N/A

## Proposed Changes

Add functionality in the validator monitor to provide sync committee related metrics for monitored validators.


Co-authored-by: Michael Sproul <[email protected]>
@bors
Copy link

bors bot commented Sep 1, 2021

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Validator monitor support for sync committees [Merged by Bors] - Validator monitor support for sync committees Sep 1, 2021
@bors bors bot closed this Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@realbigsean realbigsean realbigsean approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. v1.5.2 The release after v1.5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pawanjay176 @abharti660 @michaelsproul @realbigsean @paulhauner