[Merged by Bors] - Updates to make crates publishable #2472
Conversation
- rename `serde_util` to `eth2_serde_util` - increment minor versions - remove path dependencies
…lighthouse into make-crates-publishable
|
I pulled in #2465 to include the release script here in case we want to use it during the manual publishes. After figuring out this: #2465 (comment) |
…ke-crates-publishable
- fix version extraction - cargo fmt
realbigsean
added
ready-for-review
|
Crate publishing went pretty smoothly! |
|
Wow, rust 1.54.0 just dropped and requires a change in Good chance to test out this in CI! I added the sigp github group for crates.io to the new crates ( |
…ke-crates-publishable � Conflicts: � common/eth2/src/lighthouse_vc/http_client.rs
|
I incremented the versions on these crates because they've all had lint-related updates since I published them: So if we want to merge this to
|
…ke-crates-publishable � Conflicts: � common/rest_types/Cargo.toml
…ke-crates-publishable � Conflicts: � Cargo.lock � beacon_node/genesis/Cargo.toml � consensus/cached_tree_hash/Cargo.toml � consensus/merkle_proof/Cargo.toml � consensus/swap_or_not_shuffle/Cargo.toml � consensus/tree_hash/Cargo.toml � consensus/types/Cargo.toml � crypto/bls/Cargo.toml � lcli/Cargo.toml � validator_client/Cargo.toml � validator_client/slashing_protection/Cargo.toml
|
Since last merging with
I manually published these as well because there were small changes but there were no breaking changes associated with them: General question: should these all be 1.x.x? Because lighthouse is now running in production |
There was a problem hiding this comment.
Awesome, this will be a great contribution to Rust/Eth2 community!
I've added the CARGO_API_TOKEN token to the secrets, hopefully it works 🤞
Only one change requested from me: common/rest_types/Cargo.toml (empty file) has been raised from the dead and should be deleted again 🙏
Happy to merge once that file is deleted!
paulhauner
added
waiting-on-author
|
I think this will also resolve #1690, since we're removing the patches! |
…ke-crates-publishable
realbigsean
removed
the
waiting-on-author
paulhauner
added
ready-for-merge
|
Oops, forgot to newline the bors command! bors r+ |
## Issue Addressed Related to: #2259 Made an attempt at all the necessary updates here to publish the crates to crates.io. I incremented the minor versions on all the crates that have been previously published. We still might run into some issues as we try to publish because I'm not able to test this out but I think it's a good starting point. ## Proposed Changes - Add description and license to `ssz_types` and `serde_util` - rename `serde_util` to `eth2_serde_util` - increment minor versions - remove path dependencies - remove patch dependencies ## Additional Info Crates published: - [x] `tree_hash` -- need to publish `tree_hash_derive` and `eth2_hashing` first - [x] `eth2_ssz_types` -- need to publish `eth2_serde_util` first - [x] `tree_hash_derive` - [x] `eth2_ssz` - [x] `eth2_ssz_derive` - [x] `eth2_serde_util` - [x] `eth2_hashing` Co-authored-by: realbigsean <[email protected]>
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Issue Addressed
Related to: #2259
Made an attempt at all the necessary updates here to publish the crates to crates.io. I incremented the minor versions on all the crates that have been previously published. We still might run into some issues as we try to publish because I'm not able to test this out but I think it's a good starting point.
Proposed Changes
ssz_typesandserde_utilserde_utiltoeth2_serde_utilAdditional Info
Crates published:
tree_hash-- need to publishtree_hash_deriveandeth2_hashingfirsteth2_ssz_types-- need to publisheth2_serde_utilfirsttree_hash_deriveeth2_sszeth2_ssz_deriveeth2_serde_utileth2_hashing