[Merged by Bors] - Capture a missed VC error

[paulhauner]

Issue Addressed

Related to #2430, #2394

Proposed Changes

As per #2430 (comment), ensure that the ProductionValidatorClient::new error raises a log and shuts down the VC. Also, I implemened spawn_ignoring_error, as per @michaelsproul's suggestion in #2436 (comment).

I got unlucky and CI picked up a new rustsec vuln. To fix this, I had to update the following crates:

• tokio
• web3
• tokio-compat-02

Additional Info

NA

[michaelsproul]

This is glorious! I just tested with a few of the scenarios from #2430 and they're all fixed by this PR 🎉

---

On a related note, I noticed we often use .map(|_| ()) to throw away errors in the VC, which is fine as long as the error type is (), but could accidentally throw away non-unit errors. We could maybe add a convenience method to executor to make this pattern safer, something like spawn_ignoring_error that enforces E = (). Or a mixin trait for Result<(), ()> that adds an ignore method.

lighthouse/validator_client/src/attestation_service.rs

Lines 208 to 218 in 3b600ac

	self.inner.context.executor.spawn(
	self.clone()
	.publish_attestations_and_aggregates(
	slot,
	committee_index,
	validator_duties,
	aggregate_production_instant,
	)
	.map(|_| ()),
	"attestation publish",
	);

[paulhauner]

something like spawn_ignoring_error that enforces E = ()

Good call, I've added that too.

I had to jig around with deps to solve a cargo audit vuln. Let's see if CI still passes 🤞

[paulhauner]

Looks like Windows doesn't like the latest version of web3:

 error[E0432]: unresolved import `tokio::net::UnixStream`
  --> C:\Users\runneradmin\.cargo\registry\src\github.jparrowsec.cn-1ecc6299db9ec823\web3-0.16.0\src\transports\ipc.rs:18:5
   |
18 |     net::UnixStream,
   |     ^^^^^^^^^^^^^^^ no `UnixStream` in `net`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
error: could not compile `web3`

[michaelsproul]

Oh! They restored IPC support in v0.16, I didn't notice!

That probably only works on UNIX so we should disable it with default-features = false

https://github.com/tomusdrw/rust-web3#installation-on-windows

https://github.com/tomusdrw/rust-web3/blob/c153128c78860ce83d5d5db3ad418e18fb42da77/Cargo.toml#L68

[michaelsproul]

I think ideally we'll want some form of platform deps to enable IPC on UNIX only https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies

Actually, looks like we decided not to support IPC (#1049). We can leave it disabled for now and come back for it if we want

[paulhauner]

That probably only works on UNIX so we should disable it with default-features = false

I've redefined the features to just drop ipc-tokio, as per 0.14.0. That seemed safest.

Lets see how Windows likes that.

[michaelsproul]

Ah, need default-features = false. It's still trying to compile it

[paulhauner]

In the interests of getting this merged sooner, I'm going to skip straight to bors.

bors r+

[bors]

Pull request successfully merged into unstable.

Build succeeded:

• arbitrary-check
• cargo-audit
• cargo-fmt
• cargo-udeps
• check-benchmarks
• check-consensus
• clippy
• debug-tests-ubuntu
• dockerfile-ubuntu
• ef-tests-ubuntu
• eth1-simulator-ubuntu
• no-eth1-simulator-ubuntu
• release-tests-ubuntu
• release-tests-windows
• state-transition-vectors-ubuntu