[Merged by Bors] - Allow specifying alternative url for deposit_contract #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for downloading the deposit contract from a different location by setting the environement variables LIGHTHOUSE_DEPOSIT_CONTRACT_SPEC_URL and LIGHTHOUSE_DEPOSIT_CONTRACT_TESTNET_URL. It also adds support to fetch the content from a local file:// URL. This allows pre fetching to build in an environment without network access.
paulhauner
added
enhancement
paulhauner
approved these changes
Apr 16, 2021
paulhauner
added
ready-for-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 16, 2021
## Issue Addressed None ## Proposed Changes Adds support for downloading the deposit contract from a different location by setting the environement variables `LIGHTHOUSE_DEPOSIT_CONTRACT_SPEC_URL` and `LIGHTHOUSE_DEPOSIT_CONTRACT_TESTNET_URL`. It also adds support to fetch the content from a local file:// URL. This allows pre fetching to build in an environment without network access. ## Additional Info Being able to build without network access is required to package the application for https://nixos.org/. But I imagine it might be useful for other distributions too.
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
None
Proposed Changes
Adds support for downloading the deposit contract from a different location
by setting the environement variables
LIGHTHOUSE_DEPOSIT_CONTRACT_SPEC_URLand
LIGHTHOUSE_DEPOSIT_CONTRACT_TESTNET_URL.It also adds support to fetch the content from a local file:// URL.
This allows pre fetching to build in an environment without network access.
Additional Info
Being able to build without network access is required to package the application for https://nixos.org/. But I imagine it might be useful for other distributions too.